1637113 - android hit testing seems broken

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Timothy Nikkel (:tnikkel)]

STR, in an android browser (geckoview example, reference browser, fenix) load https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/screenX

Scroll down to the "Result" box with live update of mouse position. Pinch zoom in, tap the box. The mouse position is not updated, it should be. Also, if you long tap words they won't be selected.

I tested in a geckoview example build based off a May 3 changeset and the problem does not exist. I initially suspect bug 1556556.

Comment 1

[Botond Ballo [:botond]]

The issue first appeared in the May 6th GVE nightly, which is also the first one to include bug 1556556. I agree that it is the likely suspect.

Comment 2

[Botond Ballo [:botond]]

In a debug build, I'm seeing this assertion firing.

Comment 3

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #2)

In a debug build, I'm seeing this assertion firing.

This is only triggered when the pinch gesture to zoom in is made over the interactive "Result" box. It may be an unrelated issue.

Comment 4

[Randall Barker [:rbarker]]

If the regressing patch has been identified, can it be backed out until a fix is found?

Comment 5

[Botond Ballo [:botond]]

I'm working on a fix.

Comment 6

[Botond Ballo [:botond]]

I was able to coax RDM into reproducing this and debug it in rr. It's a bug in the changes bug 1556556 made to nsIFrame::GetTransformMatrix().

Comment 7

[Botond Ballo [:botond]]

Attachment: Bug 1637113 - Apply the offset from the canvas frame to the scroll frame before the layout-to-visual transform. r=tnikkel

This offset is essentially the layout scroll offset, to it's in layout coordinates.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1bcac66ee21
Apply the offset from the canvas frame to the scroll frame before the layout-to-visual transform. r=tnikkel

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f1bcac66ee21