Closed Bug 1637119 Opened 5 months ago Closed 4 months ago

[wpt-sync] Sync PR 23519 - Added in special case for timeline inclusive end point.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23519 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23519
Details from upstream follow.

Jordan Taylor <jortaylo@microsoft.com> wrote:

Added in special case for timeline inclusive end point.

A special case is needed for timeline current time and phase calculation
when endScrollOffset is greater than or equal to the max offset. This
special case was removed when adding timeline phase, and is now being
added back in.

https://github.com/w3c/csswg-drafts/issues/4325#issuecomment-606723725

Bug: 1046833
Change-Id: I6184f9c6059e1a091b54d86f37e4ba4b63c6bd13

Reviewed-on: https://chromium-review.googlesource.com/2195085
WPT-Export-Revision: 21463478a8cd7b589e5420dd704adca6e8440a0b

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 73 tests

Status Summary

Firefox

OK : 2
PASS: 71
FAIL: 24

Chrome

OK : 2
PASS: 23
FAIL: 1

Safari

OK : 2
FAIL: 24

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/scroll-animations/current-time.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
currentTime handles startScrollOffset and endScrollOffset together correctly: FAIL (Chrome: PASS, Safari: FAIL)
currentTime handles startScrollOffset correctly: FAIL (Chrome: PASS, Safari: FAIL)
currentTime calculates the correct time based on scrolled amount: FAIL (Chrome: PASS, Safari: FAIL)
currentTime handles endScrollOffset correctly: FAIL (Chrome: PASS, Safari: FAIL)
currentTime handles startScrollOffset > endScrollOffset correctly: FAIL (Chrome: PASS, Safari: FAIL)
currentTime adjusts correctly for the timeRange: FAIL (Chrome: PASS, Safari: FAIL)
currentTime handles endScrollOffset correctly (inclusive cases): FAIL (Chrome: PASS, Safari: FAIL)
currentTime handles startScrollOffset == endScrollOffset correctly: FAIL (Chrome: PASS, Safari: FAIL)
/scroll-animations/scroll-timeline-phases.tentative.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Timeline phase while start offset is equal to end offset and scroll offset is before start: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while scroll offset is at start: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while scroll offset is at end: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while start offset is greater than end offset and scroll offset is before end: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while start offset is greater than end offset and scroll offset is at end: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while start offset is greater than end offset and scroll offset is at start: FAIL (Chrome: PASS, Safari: FAIL)
Scroll timeline phase should be active when at scroll maximum and endScrollOffset is equal to maximum scroll offset.: FAIL (Chrome: FAIL, Safari: FAIL)
Timeline phase while start offset is greater than end offset and scroll offset is after start: FAIL (Chrome: PASS, Safari: FAIL)
Scroll timeline starts inactive, can transition to active, and then back to inactive.: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while scroll offset is in range: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while scroll offset is before start: FAIL (Chrome: PASS, Safari: FAIL)
Setting scroll timeline phase (which is readonly) throws TypeError.: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while scroll offset is after end: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while start offset is equal to end offset and scroll offset is after end: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while start offset is equal to end offset and scroll offset is at both: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while start offset is greater than end offset and scroll offset is before start: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/scroll-animations/current-time.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/scroll-animations/scroll-timeline-phases.tentative.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dc0d1d254891
[wpt PR 23519] - Added in special case for timeline inclusive end point, a=testonly
Status: REOPENED → RESOLVED
Closed: 5 months ago4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.