Closed Bug 1637161 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 23523 - Update flake8 to 3.8.1

Tracking

(firefox78 fixed)

Status:

RESOLVED FIXED

Milestone:

mozilla78

Tracking Flags:

Tracking

Status

firefox78

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

4 years ago

Sync web-platform-tests PR 23523 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23523
Details from upstream follow.

pyup-bot <github-bot@pyup.io> wrote:

Update flake8 to 3.8.1

This PR updates flake8 from 3.7.9 to 3.8.1.

<details>
<summary>Changelog</summary>

### 3.8.1
```
-------------------

You can view the 3.8.1 milestone_ on GitLab for more details.

Bugs Fixed


- Fix ``--output-file`` (regression in 3.8.0) (See also `GitLab!427`_,
  `GitLab637`_)


.. all links
.. _3.8.1 milestone:
    https://gitlab.com/pycqa/flake8/-/milestones/34

.. issue links
.. _GitLab637:
    https://gitlab.com/pycqa/flake8/issues/637

.. merge request links
.. _GitLab!427:
    https://gitlab.com/pycqa/flake8/merge_requests/427
   ```
   
  
  
   ### 3.8.0
   ```
   -------------------

You can view the `3.8.0 milestone`_ on GitLab for more details.

Bugs Fixed

Fix logical checks which report positions out of bounds (See also
GitLab!422, GitLab635)
Fix --exclude=.* accidentally matching . and .. (See also
GitLab!424, GitLab632)

Deprecations


- Add deprecation message for vcs hooks (See also `GitLab!420`_,
  `GitLab568`_)
   ```
   
  
  
   ### 3.8.0a2
   ```
   ---------------------

You can view the `3.8.0 milestone`_ on GitLab for more details.

Bugs Fixed
~~~~~~~~~~

- Fix ``type=&quot;str&quot;`` optparse options (See also `GitLab!419`_)
   ```
   
  
  
   ### 3.8.0a1
   ```
   ---------------------

You can view the `3.8.0 milestone`_ on GitLab for more details.

New Dependency Information

Remove dependency on entrypoints and add dependency on
importlib-metadata (only for python<3.8) (See also GitLab!388,
GitLab569)
Pyflakes has been updated to >= 2.2.0, < 2.3.0 (See also GitLab!417_)
pycodestyle has been updated to >= 2.6.0a1, < 2.7.0 (See also GitLab!418_)

Features


- Add ``--extend-exclude`` option to add to ``--exclude`` without overwriting
  (See also `GitLab!315`_, `GitLab535`_)

- Move argument parsing from ``optparse`` to ``argparse`` (See also
  `GitLab!341`_

- Group plugin options in ``--help`` (See also `GitLab!342`_, `GitLab565`_)

- Remove parsing of ``verbose`` from configuration files as it was not
  consistently applied (See also `GitLab!360`_, `GitLab439`_)

- Remove parsing of ``output_file`` from configuration files as it was not
  consistently applied (See also `GitLab!361`_)

- Resolve configuration files relative to ``cwd`` instead of common prefix of
  passed filenames.  You may need to change ``flake8 subproject`` to
  ``cd subproject &amp;&amp; flake8 .`` (See also `GitLab!363`_)

- Officially support python3.8 (See also `GitLab!377`_)

- ``--disable-noqa`` now also disables `` flake8: noqa`` (See also
  `GitLab!380`_, `GitLab590`_)

- Ensure that a missing file produces a ``E902`` error (See also `GitLab!404`_,
  `GitLab600`_)

- `` noqa`` comments now apply to all of the lines in an explicit ``\``
  continuation or in a line continued by a multi-line string (See also
  `GitLab!413`_, `GitLab375`_)

Bugs Fixed

Fix --exclude=./t.py to only match t.py at the top level (See also
GitLab!311, GitLab382)
Fix --show-source when a file is indented with tabs (See also
GitLab!339, GitLab563)
Fix crash when --max-line-length is given a non-integer (See also
GitLab!341, GitLab541)
Prevent flip-flopping of indent_char causing extra E101 errors (See
also GitLab!357, pycodestyle886)
Only enable multiprocessing when the method is fork fixing issues
on macos with python3.8+ (See also GitLab!366, GitLab587) (note: this
fix also landed in 3.7.9)
noqa is now only handled by flake8 fixing specific-noqa. Plugins
requesting this parameter will always receive False (See also
GitLab!331, GitLab552)
Fix duplicate loading of plugins when invoked via python -m flake8 (See
also GitLab!388_)
Fix early exit when --exit-zero and --diff are provided and the diff
is empty (See also GitLab!391_)
Consistently split lines when \f is present when reading from stdin (See
also GitLab!406, GitLab270)

Deprecations


- ``python setup.py flake8`` (setuptools integration) is now deprecated and
  will be removed in a future version (See also `GitLab!330`_, `GitLab544`_)

- ``type=&#39;string&#39;`` (optparse) types are deprecated, use
  ``type=callable`` (argparse) instead.  Support for ``type=&#39;string&#39;`` will
  be removed in a future version (See also `GitLab!341`_)

- ``%default`` in plugin option help text is deprecated, use ``%(default)s``
  instead.  Support for ``%default`` will be removed in a future version (See
  also `GitLab!341`_)

- optparse-style ``action=&#39;callback&#39;`` setting for options is deprecated, use
  argparse action classes instead.  This will be removed in a future version
  (See also `GitLab!341`_)


.. all links
.. _3.8.0 milestone:
    https://gitlab.com/pycqa/flake8/-/milestones/32

.. merge request links
.. _GitLab270:
   https://gitlab.com/pycqa/flake8/-/issues/270
.. _GitLab375:
   https://gitlab.com/pycqa/flake8/-/issues/375
.. _GitLab382:
   https://gitlab.com/pycqa/flake8/-/issues/382
.. _GitLab439:
   https://gitlab.com/pycqa/flake8/-/issues/439
.. _GitLab535:
   https://gitlab.com/pycqa/flake8/-/issues/535
.. _GitLab541:
   https://gitlab.com/pycqa/flake8/-/issues/541
.. _GitLab544:
   https://gitlab.com/pycqa/flake8/-/issues/544
.. _GitLab552:
   https://gitlab.com/pycqa/flake8/-/issues/552
.. _GitLab563:
   https://gitlab.com/pycqa/flake8/-/issues/563
.. _GitLab565:
   https://gitlab.com/pycqa/flake8/-/issues/565
.. _GitLab568:
   https://gitlab.com/pycqa/flake8/-/issues/568
.. _GitLab569:
   https://gitlab.com/pycqa/flake8/-/issues/569
.. _GitLab587:
   https://gitlab.com/pycqa/flake8/-/issues/587
.. _GitLab590:
   https://gitlab.com/pycqa/flake8/-/issues/590
.. _GitLab600:
   https://gitlab.com/pycqa/flake8/-/issues/600
.. _GitLab632:
   https://gitlab.com/pycqa/flake8/-/issues/632
.. _GitLab635:
   https://gitlab.com/pycqa/flake8/-/issues/635
.. _pycodestyle886:
   https://github.com/PyCQA/pycodestyle/issues/886

.. issue links
.. _GitLab!311:
   https://gitlab.com/pycqa/flake8/-/merge_requests/311
.. _GitLab!315:
   https://gitlab.com/pycqa/flake8/-/merge_requests/315
.. _GitLab!330:
   https://gitlab.com/pycqa/flake8/-/merge_requests/330
.. _GitLab!331:
   https://gitlab.com/pycqa/flake8/-/merge_requests/331
.. _GitLab!339:
   https://gitlab.com/pycqa/flake8/-/merge_requests/339
.. _GitLab!341:
   https://gitlab.com/pycqa/flake8/-/merge_requests/341
.. _GitLab!342:
   https://gitlab.com/pycqa/flake8/-/merge_requests/342
.. _GitLab!357:
   https://gitlab.com/pycqa/flake8/-/merge_requests/357
.. _GitLab!360:
   https://gitlab.com/pycqa/flake8/-/merge_requests/360
.. _GitLab!361:
   https://gitlab.com/pycqa/flake8/-/merge_requests/361
.. _GitLab!363:
   https://gitlab.com/pycqa/flake8/-/merge_requests/363
.. _GitLab!366:
   https://gitlab.com/pycqa/flake8/-/merge_requests/366
.. _GitLab!377:
   https://gitlab.com/pycqa/flake8/-/merge_requests/377
.. _GitLab!380:
   https://gitlab.com/pycqa/flake8/-/merge_requests/380
.. _GitLab!388:
   https://gitlab.com/pycqa/flake8/-/merge_requests/388
.. _GitLab!391:
   https://gitlab.com/pycqa/flake8/-/merge_requests/391
.. _GitLab!404:
   https://gitlab.com/pycqa/flake8/-/merge_requests/404
.. _GitLab!406:
   https://gitlab.com/pycqa/flake8/-/merge_requests/406
.. _GitLab!413:
   https://gitlab.com/pycqa/flake8/-/merge_requests/413
.. _GitLab!417:
   https://gitlab.com/pycqa/flake8/-/merge_requests/417
.. _GitLab!418:
   https://gitlab.com/pycqa/flake8/-/merge_requests/418
.. _GitLab!419:
   https://gitlab.com/pycqa/flake8/-/merge_requests/419
.. _GitLab!420:
   https://gitlab.com/pycqa/flake8/-/merge_requests/420
.. _GitLab!422:
   https://gitlab.com/pycqa/flake8/-/merge_requests/422
.. _GitLab!424:
   https://gitlab.com/pycqa/flake8/-/merge_requests/424
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/flake8
  - Changelog: https://pyup.io/changelogs/flake8/
  - Repo: https://gitlab.com/pycqa/flake8
</details>

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

4 years ago

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=8202ea88a8637cba23396d06dc186671c5461fb0

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

4 years ago

Depends on: 1638272

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

4 years ago

Depends on: 1639629

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

4 years ago

Test result changes from PR not available.

Pulsebot

Comment 3

•

4 years ago

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5e645f708304
[wpt PR 23523] - Update flake8 to 3.8.1, a=testonly

Natalia Csoregi [:nataliaCs]

Comment 4

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/5e645f708304

Status: NEW → RESOLVED

Closed: 4 years ago

status-firefox78: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla78

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Quick Search

[wpt-sync] Sync PR 23523 - Update flake8 to 3.8.1

Categories

(Testing :: web-platform-tests, task, P4)

Tracking

(firefox78 fixed)

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Comment 1

Updated

Updated

Comment 2

Comment 3

Comment 4