Closed Bug 1637177 Opened 4 years ago Closed 4 years ago

moz-phab: Misleading error message when using git cinnabar but not available in the path

Categories

(Conduit :: moz-phab, defect, P3)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Sylvestre, Assigned: zalun)

Details

(Keywords: conduit-triaged)

Attachments

(1 file)

Benoit (as cc of this bug) was trying to contribute to Firefox on Windows.
Pushing with moz-phab, he had the error:

Git Cinnabar extension is required to work on this repository. Local VCS (git) is different from the one defined in the repository (hg).

https://github.com/mozilla-conduit/review/blob/bedfc5c59faf31815e971344729c3e870ed03535/mozphab/repository.py#L321-L323

disable this check, he noticed that git cinnabar wasn't in the PATH; causing this error.
While it is a legit error, we should probably provide a better message.
Glob suggested that " just state the cinnabar might not be installed correctly "

Assignee: nobody → pzalewa
Status: NEW → ASSIGNED
Assignee: pzalewa → nobody
Status: ASSIGNED → NEW
Keywords: conduit-triaged
Priority: -- → P3
Assignee: nobody → pzalewa
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: