1637194 - Store first-party domain in CookieJarSetting

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P1)

Description

[Dimi Lee [:dimi][:dlee]]

Currently dFPI doesn't work in Fission since storagePrincipal has a incorrect first-party domain.
It's because when we call StoragePrincipalHelper::ChooseOriginAttributes()[1] , it sets FPD through loadInfo's topLevelPrincipal, which is wrong in Fission because topLevelPrincipal is from the in-process top.

We are considering putting FPD in CookieJarSettings.

[1] https://searchfox.org/mozilla-central/rev/446160560bf32ebf4cb7c4e25d7386ee22667255/toolkit/components/antitracking/StoragePrincipalHelper.cpp#19

Comment 1

[Dimi Lee [:dimi][:dlee]]

Attachment: Bug 1637194 - P1. Add firstPartyDomain to CookieJarSetting

Comment 2

[Dimi Lee [:dimi][:dlee]]

Attachment: Bug 1637194 - P2. Set firstPartyDomain to CookieJarSetting in nsHttpChannel::AsyncOpen

FirstPartyDomain is only set while loading a top-level document.
We added in nsHttpChannel::AsyncOpen to ensure that the value is updated
whenever we open a channel.

Depends on D75276

Comment 3

[Dimi Lee [:dimi][:dlee]]

Attachment: Bug 1637194 - P3. StoragePrincipalHelper uses firstPartyDomain in CookieJarSetting

Depends on D75277

Comment 4

[Dimi Lee [:dimi][:dlee]]

Attachment: Bug 1637194 - P3. StoragePrincipalHelper uses firstPartyDomain in CookieJarSetting

Comment 5

[Dimi Lee [:dimi][:dlee]]

Attachment: Bug 1637194 - P4. Inherit the first-party domain from the parent document when creating CookieJarSetting in document

This fixes a issue that about:blank page can't get correct first-party
domain when fission is enabled.

Depends on D75783

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7dfa75d822d
P1. Add firstPartyDomain to CookieJarSetting r=timhuang,baku
https://hg.mozilla.org/integration/autoland/rev/57be6fd91c48
P2. Set firstPartyDomain to CookieJarSetting in nsHttpChannel::AsyncOpen r=necko-reviewers,timhuang,baku,kershaw
https://hg.mozilla.org/integration/autoland/rev/bd808346ec6e
P3. StoragePrincipalHelper uses firstPartyDomain in CookieJarSetting r=timhuang,baku
https://hg.mozilla.org/integration/autoland/rev/643eb857ad96
P4. Inherit the first-party domain from the parent document when creating CookieJarSetting in document r=timhuang,baku

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e7dfa75d822d
https://hg.mozilla.org/mozilla-central/rev/57be6fd91c48
https://hg.mozilla.org/mozilla-central/rev/bd808346ec6e
https://hg.mozilla.org/mozilla-central/rev/643eb857ad96