1637217 - Implement telemetry for Amazon Tile Replacement

Status: VERIFIED FIXED

(Firefox :: New Tab Page, task, P1)

Description

[Dão Gottwald [:dao]]

Exactly what probes we need here is yet to be decided.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1637217 - Implement telemetry for Amazon Tile Replacement. r=mikedeboer

Comment 2

[Jan-Erik Rediger [:janerik]]

Telemetry peer here.
As a reminder before landing this data review is required. Additionally in most circumstances it is required for data review to be public.
Keep that in mind or let the data reviewer know why it isn't possible in this case.
See https://wiki.mozilla.org/Firefox/Data_Collection#Requesting_Data_Collection for more.

Comment 3

[Dão Gottwald [:dao]]

Attachment: 1637217-data-review

Comment 4

[Ben Miroglio [:bmiroglio]]

Comment on attachment 9153794 [details]
1637217-data-review

# Data Review Form 

1) Is there or will there be **documentation** that describes the schema for the ultimate data set in a public, complete, and accurate way? 

This will be documented in the [Events.yaml file[(https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/event-ping.html). Note this is data specific to an experiment at this moment in time.

2) Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Users can disable this by opt-ing out of Telemetry in the Firefox preferences.


3) If the request is for permanent data collection, is there someone who will monitor the data over time?

This is not permanent.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2: Interaction Data

5) Is the data collection request for default-on or default-off?

default-off. This is only default on for the experiment.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

No. We will need to re-request/review should we implement it outside of the experiment..

9) Does the data collection use a third-party collection tool?

No.

data-review: r+

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/17d4bfd58df16f9dd58e6a439489eeba107e5940
https://hg.mozilla.org/mozilla-central/rev/17d4bfd58df1

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 9153417 [details]
Bug 1637217 - Implement telemetry for Amazon Tile Replacement. r=mikedeboer

Beta/Release Uplift Approval Request

• User impact if declined: We need this for the Amazon and Google tile replacement experiments
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: We have a QA process for the experiments, this will be verified as part of that
• List of other uplifts needed: bug 1637218
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): These probes aren't sent by default, only to be sent as part of the experiments
• String changes made/needed:

Comment 7

[Jan-Erik Rediger [:janerik]]

As per my earlier comment #2: What's the reason for this bug being confidential?
From https://wiki.mozilla.org/Firefox/Data_Collection#Key_Roles_for_Data_Collection

Mozilla always strives to make data reviews public.
However, there are sometimes limited sets of circumstances when we may conduct our reviews in a private bug;
for example, a service is part of an agreement where the partnership is not yet public.
These reviews will be made public once the actual data collection begins.

As this now landed in nightly and is also supposed to be uplifted I strongly advise to make at a minimum the data review itself public (this can be done in a separate public bug)

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9153417 [details]
Bug 1637217 - Implement telemetry for Amazon Tile Replacement. r=mikedeboer

approved for 78.0b4

Comment 9

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cdd274b9ae8e

Comment 10

[Robert Martin [:romartin], Ecosystem QA]

For Firefox 78, this task was verified as part of the work done in [PI-606] Modify Amazon Search Shortcut to a direct link to Amazon.com experiment.
For Firefox 79, I have verified that the correct telemetry pings for the Amazon tile are displayed, on Firefox Nightly 79.0a1 on Windows 10 x64, macOS 10.15, and Ubuntu Linux 18.04, after the following actions on the tile:

• Unpin the tile.
• Pin the tile.
• Move the tile in a different position.
• Click the tile.
• Open the tile in a new window.
• Open the tile in a new private video.
• Dismiss the tile.
  Considering the above, I am marking this task as VERIFIED.