Closed Bug 1637276 Opened 4 years ago Closed 4 years ago

Overlay menu does not render in macos x 10.15

Categories

(Core :: Widget: Cocoa, defect, P3)

78 Branch
defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: jackysee, Unassigned)

References

(Regression)

Details

(Keywords: regression)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15) AppleWebKit/605.1.15 (KHTML, like Gecko) FxiOS/24.1 Safari/605.1.15

Steps to reproduce:

Right click menu on webpage. Click on toolbar which will have overlay menu like security badge, bookmark icon, etc

Actual results:

Right click menu has empty content. Toolbar overlay menu didn’t appear. Please check the video here https://twitter.com/jackysee/status/1257453754338680833

Expected results:

Menu should appear and have correct render

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Widget: Cocoa
Product: Firefox → Core

Are you able to reproduce this reliably? Do you have to be on a specific page to be able to reproduce? Anything else needed to get into this state?

Flags: needinfo?(jackysee)
Priority: -- → P3

Are you able to reproduce this reliably?
Yes

Do you have to be on a specific page to be able to reproduce?
Any page will do.

Anything else needed to get into this state?
Nothing. It just appears in some recent versions of nightly.

Flags: needinfo?(jackysee)

Could you run mozregression[1] to see when this started happening? If you have never run mozregression before, simply run these three commands in a Terminal window:

sudo easy_install pip
sudo pip install -U mozregression --ignore-installed
mozregression

A number of Firefox versions will open in succession to narrow down when this started occurring. Simply type "good" or "bad" in Terminal based on whether or not a build reproduces the bug. Once finished, please post the output from the last run. It should give a last good and first bad revision as well as a link to look at the changesets in that range. Thank you!

[1] https://mozilla.github.io/mozregression/

Flags: needinfo?(jackysee)

Can't get it started.

 mozregression
**********
You should use a config file. Please use the --write-config command line flag to help you create one.
**********

 0:00.13 INFO: No 'bad' option specified, using 2020-05-13
 0:00.13 INFO: No 'good' option specified, using 2009-01-01
 0:00.61 WARNING: Skipping build 2020-05-13: Unable to find build info for 2020-05-13
 0:00.87 INFO: Testing good and bad builds to ensure that they are really good and bad...
 0:00.87 INFO: Downloading build from: https://archive.mozilla.org/pub/firefox/nightly/2009/01/2009-01-01-02-mozilla-central/firefox-3.2a1pre.en-US.mac.dmg
===== Downloaded 100% =====
 0:03.17 INFO: Running mozilla-central build for 2009-01-01
 0:09.30 INFO: Launching /private/var/folders/0m/_myg74lx1zv_nnvqxfpy1cp40000gn/T/tmp_6tyfag7/Minefield.app/Contents/MacOS/firefox-bin
 0:09.30 INFO: Application command: /private/var/folders/0m/_myg74lx1zv_nnvqxfpy1cp40000gn/T/tmp_6tyfag7/Minefield.app/Contents/MacOS/firefox-bin --allow-downgrade -foreground -profile /var/folders/0m/_myg74lx1zv_nnvqxfpy1cp40000gn/T/tmpsftqqmvu.mozrunner
['/private/var/folders/0m/_myg74lx1zv_nnvqxfpy1cp40000gn/T/tmp_6tyfag7/Minefield.app/Contents/MacOS/firefox-bin', '--allow-downgrade', '-foreground', '-profile', '/var/folders/0m/_myg74lx1zv_nnvqxfpy1cp40000gn/T/tmpsftqqmvu.mozrunner']
 0:09.31 ERROR: Unable to start the application (error: 'str' object has no attribute '__traceback__')
 0:09.46 ERROR: Unable to start the application (error: 'str' object has no attribute '__traceback__')
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/mozrunner/base/runner.py", line 131, in start
    process.run(self.timeout, self.output_timeout)
  File "/usr/local/lib/python3.7/site-packages/mozprocess/processhandler.py", line 811, in run
    self.proc = self.Process([self.cmd] + self.args, **args)
  File "/usr/local/lib/python3.7/site-packages/mozprocess/processhandler.py", line 123, in __init__
    universal_newlines, startupinfo, creationflags)
  File "/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/lib/python3.7/subprocess.py", line 800, in __init__
    restore_signals, start_new_session)
  File "/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/lib/python3.7/subprocess.py", line 1551, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
OSError: [Errno 86] Bad CPU type in executable: '/private/var/folders/0m/_myg74lx1zv_nnvqxfpy1cp40000gn/T/tmp_6tyfag7/Minefield.app/Contents/MacOS/firefox-bin'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/mozregression/launchers.py", line 68, in start
    self._start(**kwargs)
  File "/usr/local/lib/python3.7/site-packages/mozregression/launchers.py", line 338, in _start
    profile, addons, ["--allow-downgrade"] + cmdargs, preferences, adb_profile_dir,
  File "/usr/local/lib/python3.7/site-packages/mozregression/launchers.py", line 242, in _start
    self.runner.start()
  File "/usr/local/lib/python3.7/site-packages/mozrunner/base/browser.py", line 85, in start
    BaseRunner.start(self, *args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/mozrunner/base/runner.py", line 136, in start
    reraise(RunnerNotStartedError, "Failed to start the process: %s" % value, tb)
  File "/usr/local/lib/python3.7/site-packages/six.py", line 701, in reraise
    if value.__traceback__ is not tb:
AttributeError: 'str' object has no attribute '__traceback__'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/mozregression/main.py", line 332, in main
    sys.exit(method())
  File "/usr/local/lib/python3.7/site-packages/mozregression/main.py", line 132, in bisect_nightlies
    result = self._do_bisect(handler, good_date, bad_date)
  File "/usr/local/lib/python3.7/site-packages/mozregression/main.py", line 224, in _do_bisect
    return self.bisector.bisect(handler, good, bad, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/mozregression/bisector.py", line 601, in bisect
    return self._bisect(handler, build_range)
  File "/usr/local/lib/python3.7/site-packages/mozregression/bisector.py", line 625, in _bisect
    if bisection.ensure_good_and_bad():
  File "/usr/local/lib/python3.7/site-packages/mozregression/bisector.py", line 527, in ensure_good_and_bad
    if _evaluate(good, "good"):
  File "/usr/local/lib/python3.7/site-packages/mozregression/bisector.py", line 512, in _evaluate
    res = self.test_runner.evaluate(build_info)
  File "/usr/local/lib/python3.7/site-packages/mozregression/test_runner.py", line 119, in evaluate
    launcher.start(**self.launcher_kwargs)
  File "/usr/local/lib/python3.7/site-packages/mozregression/launchers.py", line 72, in start
    six.reraise(LauncherError, LauncherError(msg), sys.exc_info()[2])
  File "/usr/local/lib/python3.7/site-packages/six.py", line 702, in reraise
    raise value.with_traceback(tb)
  File "/usr/local/lib/python3.7/site-packages/mozregression/launchers.py", line 68, in start
    self._start(**kwargs)
  File "/usr/local/lib/python3.7/site-packages/mozregression/launchers.py", line 338, in _start
    profile, addons, ["--allow-downgrade"] + cmdargs, preferences, adb_profile_dir,
  File "/usr/local/lib/python3.7/site-packages/mozregression/launchers.py", line 242, in _start
    self.runner.start()
  File "/usr/local/lib/python3.7/site-packages/mozrunner/base/browser.py", line 85, in start
    BaseRunner.start(self, *args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/mozrunner/base/runner.py", line 136, in start
    reraise(RunnerNotStartedError, "Failed to start the process: %s" % value, tb)
  File "/usr/local/lib/python3.7/site-packages/six.py", line 701, in reraise
    if value.__traceback__ is not tb:
mozregression.errors.LauncherError: Unable to start the application (error: 'str' object has no attribute '__traceback__')
During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/mozregression/main.py", line 342, in main
    sys.exit(1)
SystemExit: 1

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/mozregression", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.7/site-packages/mozregression/main.py", line 345, in main
    app.clear()
  File "/usr/local/lib/python3.7/site-packages/mozregression/main.py", line 76, in clear
    self._build_download_manager.wait(raise_if_error=False)
  File "/usr/local/lib/python3.7/site-packages/mozregression/download_manager.py", line 270, in wait
    for download in downloads:
RuntimeError: dictionary changed size during iteration
Exception ignored in: <function BaseProfile.__del__ at 0x10f57c290>
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/mozprofile/profile.py", line 77, in __del__
  File "/usr/local/lib/python3.7/site-packages/mozprofile/profile.py", line 259, in cleanup
  File "/usr/local/lib/python3.7/site-packages/mozprofile/profile.py", line 273, in clean_preferences
  File "/usr/local/lib/python3.7/site-packages/mozprofile/profile.py", line 322, in pop_preferences
NameError: name 'open' is not defined
Flags: needinfo?(jackysee)

It's trying to use a build from 2009-01-01 which will be a 32bit build which is not supported by 10.15. So you'll need to give it a starting build that is newer. Like this

mozregression --good 2019-09-01

You can replace the date with a better guess for a date when the problem did not happen. If you get it wrong (and the good build actually has the problem) mozregression will tell you.

Flags: needinfo?(jackysee)
13:25.64 INFO: No more integration revisions, bisection finished.
13:25.64 INFO: Last good revision: 92bb542ff11aa1f133a27ac7a445a71c79dde661
13:25.64 INFO: First bad revision: 152bfc05a5091be5d366580d6cbdd1e6fd54eb79
13:25.64 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=92bb542ff11aa1f133a27ac7a445a71c79dde661&tochange=152bfc05a5091be5d366580d6cbdd1e6fd54eb79

I don't remembered this bug happened in last year. I think it may relate to OS update? It's macOS Catalina 10.15.4 (19E287) now.

Flags: needinfo?(jackysee)

Also cannot find gfx.core-animation.enabled in about:config for latest build

Thanks.

(In reply to jackysee from comment #8)

Also cannot find gfx.core-animation.enabled in about:config for latest build

The pref was removed shortly after it was enabled by default so that code could be cleaned up and simplified.

Flags: needinfo?(mstange)
Regressed by: 1574538
Has Regression Range: --- → yes

The problem has gone after updated to mac osx 10.15.5 (19F101) with firefox nightly 79.0a1 (2020-06-03) (64-bit)

Thanks for letting us know!

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Flags: needinfo?(mstange)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.