1637347 - Crash in [@ cubeb_coreaudio::backend::get_buffer_size]

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[Alex Chronopoulos [:achronop]]

This bug is for crash report bp-2855fd52-74f2-4e4a-9179-4c2920200510.

Top 10 frames of crashing thread:

0 XUL RustMozCrash mozglue/static/rust/wrappers.cpp:17
1 XUL mozglue_static::panic_hook mozglue/static/rust/lib.rs:89
2 XUL core::ops::function::Fn::call src/libcore/ops/function.rs:72
3 XUL std::panicking::rust_panic_with_hook src/libstd/panicking.rs:474
4 XUL rust_begin_unwind src/libstd/panicking.rs:378
5 XUL std::panicking::begin_panic_fmt src/libstd/panicking.rs:332
6 XUL cubeb_coreaudio::backend::get_buffer_size third_party/rust/cubeb-coreaudio/src/backend/mod.rs:1140
7 XUL cubeb_coreaudio::backend::set_buffer_size_sync third_party/rust/cubeb-coreaudio/src/backend/mod.rs:1178
8 XUL cubeb_coreaudio::backend::CoreStreamData::setup third_party/rust/cubeb-coreaudio/src/backend/mod.rs:2745
9 XUL <cubeb_coreaudio::backend::AudioUnitContext as cubeb_backend::traits::ContextOps>::stream_init third_party/rust/cubeb-coreaudio/src/backend/mod.rs:2227

Started in 20200309095159

Comment 1

[C.M.Chang[:chunmin]]

It hit an assertion that check the queried buffer-frame-size cannot be 0, when setting the new buffere-frame-size.

We can simply remove that assertion and just make sure the buffer-frame-size we set is not 0.

Comment 2

[C.M.Chang[:chunmin]]

Attachment: GitHub Pull Request

Comment 3

[C.M.Chang[:chunmin]]

Landed via bug 1644080