1637351 - GVE needs to implement onKill

Status: RESOLVED FIXED

(GeckoView :: GeckoViewExample, task, P2)

Description

[(No longer employed by Mozilla) Aaron Klotz]

Otherwise content process termination won't be picked up and handled.

As a reference application, we should be smart about this wrt whether the active session was killed, or a background session.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1637351: Add onKill handler to GVE; r=#geckoview-reviewers

Since GVE is supposed to be an exemplar for using GV the Right Way (TM), we
add an onKill handler that checks whether the killed session is current, and
does not restore the session if it is in the background.

When switching sessions, we add a check to see whether the session was closed,
and reopen it if so.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b195f27085be
Add onKill handler to GVE; r=geckoview-reviewers,agi

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset b195f27085be (bug 1637351) for causing perma Raptor failures on Android. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317004308&repo=autoland&lineNumber=1807

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=b195f27085beaa5fc62296efa15933a1bf57b1b2

Backout:
https://hg.mozilla.org/integration/autoland/rev/661294ad73578c643850c6122698c2b5d04e097f

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eaebac57f413
Add onKill handler to GVE; r=geckoview-reviewers,agi

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/eaebac57f413