Closed
Bug 1637402
Opened 4 years ago
Closed 4 years ago
Determine quality of MLS results
Categories
(Firefox :: Search, task, P1)
Firefox
Search
Tracking
()
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: daleharvey, Assigned: daleharvey)
References
Details
Attachments
(2 files, 1 obsolete file)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
2.22 KB,
text/plain
|
chutten
:
data-review+
|
Details |
No description provided.
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → dharvey
Severity: -- → S3
Iteration: --- → 78.1 - May 4 - May 17
Priority: -- → P1
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
Attachment #9148027 -
Flags: data-review?(chutten)
Updated•4 years ago
|
Iteration: 78.1 - May 4 - May 17 → 78.2 - May 18 - May 31
Comment 3•4 years ago
|
||
Comment on attachment 9148027 [details]
Data Review Request
Could you please explain in your review form what kind of data this will be? Is this a Histogram where each sample is the distance for a given reading? Is it a Scalar which sums the distances over time?
Flags: needinfo?(dharvey)
Attachment #9148027 -
Flags: data-review?(chutten)
Assignee | ||
Comment 4•4 years ago
|
||
Attachment #9148027 -
Attachment is obsolete: true
Flags: needinfo?(dharvey)
Assignee | ||
Comment 5•4 years ago
|
||
Cheers, added the type, we are looking for a histogram so we can answer how many of these requests return the same / extremely close results, how many are far off etc
Assignee | ||
Updated•4 years ago
|
Attachment #9149347 -
Flags: data-review?(chutten)
Comment 6•4 years ago
|
||
Comment on attachment 9149347 [details] Data Review Request DATA COLLECTION REVIEW RESPONSE: Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/). Is there a control mechanism that allows the user to turn the data collection on and off? Yes. This collection is Telemetry so can be controlled through Firefox's Preferences. If the request is for permanent data collection, is there someone who will monitor the data over time? No. This collection will expire in six months. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? Category 1, Technical. Is the data collection request for default-on or default-off? Default on for pre-release channels only. Does the instrumentation include the addition of any new identifiers? No. Is the data collection covered by the existing Firefox privacy notice? Yes. Does there need to be a check-in in the future to determine whether to renew the data? Yes. Dale Harvey is responsible for renewing or removing the collection before it expires in six months. --- Result: datareview+
Attachment #9149347 -
Flags: data-review?(chutten) → data-review+
Updated•4 years ago
|
Attachment #9147767 -
Attachment description: Bug 1637402 - Add pref to compare MLS results → sBug 1637402 - Add pref to compare MLS results
Updated•4 years ago
|
Attachment #9147767 -
Attachment description: sBug 1637402 - Add pref to compare MLS results → Bug 1637402 - Add pref to compare MLS results
Pushed by dharvey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/10807c4612a8 Add pref to compare MLS results r=chutten,mikedeboer
Comment 9•4 years ago
|
||
Backed out for perma failure on test_location_services_telemetry.html.
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304599461&repo=autoland&lineNumber=3017
Backout: https://hg.mozilla.org/integration/autoland/rev/5f343f8d2fdc8dac00688e50b70d337417e95714
Flags: needinfo?(dharvey)
Comment 10•4 years ago
|
||
Pushed by dharvey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/34aa06cff443 Add pref to compare MLS results r=chutten,mikedeboer
Assignee | ||
Comment 11•4 years ago
|
||
ok so android failed because we dont collect telemetry on android, added a skip-if for android, and test-verify looks like it failed because the new test added is quite slow due to the geolocation api usage, added a requestLongerTimeout and test-verify is passing now on try runs so relanded.
Flags: needinfo?(dharvey)
Comment 12•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
You need to log in
before you can comment on or make changes to this bug.
Description
•