1637424 - Support generators in self-hosted code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Adam Vandolder [:avandolder]]

Generator functions currently can't be defined in self-hosted code, as they requires the Iterator prototype to be already defined, leading to the following error when attempting to run the JS console:

Assertion failure: shape, at /js/src/vm/SelfHosting.cpp:2763

Comment 1

[Jason Orendorff [:jorendorff]]

The first hurdle is to stop giving prototypes to self-hosted functions that live in the self-hosted realm. That part is easy.

The second hurdle is to make JSFunction::generatorKind() work for lazy self-hosted functions.

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1637424 - Part 1: Support self-hosted builtins possibly being generators in JSFunction::generatorKind(). r?tcampbell.

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1637424 - Part 2: Prevent runaway recursion when compiling self-hosted generators. r?tcampbell.

Depends on D75219

Comment 4

[Jason Orendorff [:jorendorff]]

Work-in-progress patches. Still failing a few warp tests, but Adam, if you apply these locally, you should be able to get a little farther at least.

Comment 5

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1637424 - Part 3: Delete an unused argument. r?tcampbell.

Depends on D75220

Comment 6

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1637424 - Part 4: Select the correct [[Prototype]] for self-hosted functions, based on kind. r?tcampbell.

Depends on D76336

Comment 7

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1637424 - Part 5: Prevent runaway recursion setting up %IteratorPrototype%. r?tcampbell.

Depends on D76337

Comment 8

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1637424 - Part 1.1: Make some functions to access uncloned self-hosted values infallible. r?tcampbell.

Depends on D75219

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c424830cdaf9
Part 1: Support self-hosted builtins possibly being generators in JSFunction::generatorKind(). r=tcampbell.
https://hg.mozilla.org/integration/autoland/rev/b0dd4d14f584
Part 1.1: Make some functions to access uncloned self-hosted values infallible. r=tcampbell.
https://hg.mozilla.org/integration/autoland/rev/d119bd2522d8
Part 2: Prevent runaway recursion when compiling self-hosted generators. r=tcampbell.
https://hg.mozilla.org/integration/autoland/rev/9f6e9f146c37
Part 3: Delete an unused argument. r=tcampbell.
https://hg.mozilla.org/integration/autoland/rev/da3acd236f47
Part 4: Select the correct [[Prototype]] for self-hosted functions, based on kind. r=tcampbell.
https://hg.mozilla.org/integration/autoland/rev/8acea7464a54
Part 5: Prevent runaway recursion setting up %IteratorPrototype%. r=tcampbell.

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c424830cdaf9
https://hg.mozilla.org/mozilla-central/rev/b0dd4d14f584
https://hg.mozilla.org/mozilla-central/rev/d119bd2522d8
https://hg.mozilla.org/mozilla-central/rev/9f6e9f146c37
https://hg.mozilla.org/mozilla-central/rev/da3acd236f47
https://hg.mozilla.org/mozilla-central/rev/8acea7464a54