Closed Bug 1637498 Opened 5 years ago Closed 5 years ago

Don't hardcode Pocket in Reader Mode string

Categories

(Toolkit :: Reader Mode, defect)

defect

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: flod, Assigned: flod)

References

Details

Attachments

(1 file)

Bug 1550836 introduced a string with an hard-coded brand. That's not great, because we have seen many locales translating those brands, and we need better control. Unfortunately it slipped through the amount of comments.

readerView.savetopocket.label=Save To Pocket

I haven't exposed the string to locale yet, so we can fix it without a new ID.

Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/73b01405aed3 Don't hardcode Pocket in Reader Mode string r=Gijs
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
Regressions: 1643067
No longer regressions: 1643067
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: