1637544 - Enable sccache on instrumented builds for try & autoland

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, enhancement)

Description

[Marco Castelluccio [:marco]]

sccache is currently disabled on builds such as instrumented-build-linux64-shippable/opt.

Comment 1

[Mike Hommey [:glandium]]

Note: that was deliberately disabled over security concerns (bug 1583368), but could be enabled as long as we don't enable it in actual nightlies and releases. Which means this conflicts with release promotion if that's still a thing, and isn't just a matter of enabling sccache because doing so would enable it on nightlies in the current state of taskcluster configuration.

Comment 2

[Tom Prince [:tomprince]]

We could enable it only on autoland, as long as we are careful that it is never enabled on any release branch (including mozilla-central)

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Let's start doing it for autoland. I will see if I can find an owner to do it.

I would like also to discuss again bug 1583368 with some folks.

Comment 4

[Marco Castelluccio [:marco]]

We can enable it on try too.

Comment 5

[Marco Castelluccio [:marco]]

Attachment: Bug 1637544 - Support project-specific verifications in taskgraph. r=tomprince

Comment 6

[Marco Castelluccio [:marco]]

Attachment: Bug 1637544 - Run no-sccache verification only on release projects. r=tomprince

Depends on D77247

Comment 7

[Marco Castelluccio [:marco]]

Attachment: Bug 1637544 - Support keying 'fetches' by project. r=tomprince

Depends on D77248

Comment 8

[Marco Castelluccio [:marco]]

Attachment: Bug 1637544 - Enable sccache for instrumented builds on autoland. r=tomprince

Depends on D77646

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34928e9b270f
Support project-specific verifications in taskgraph. r=tomprince
https://hg.mozilla.org/integration/autoland/rev/c68a5eed5cee
Run no-sccache verification only on release projects. r=tomprince

Comment 10

[Marco Castelluccio [:marco]]

Attachment: Bug 1637544 - Add a 'project' to the fake parameters used during taskgraph tests. r=tomprince DONTBUILD

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54213cccb27a
Add a 'project' to the fake parameters used during taskgraph tests. r=tomprince DONTBUILD

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/34928e9b270f
https://hg.mozilla.org/mozilla-central/rev/c68a5eed5cee
https://hg.mozilla.org/mozilla-central/rev/54213cccb27a

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Tom, Marco told me that you are planning to finish this. Do you have an eta?
This represents a lot of saving.
thanks!

Comment 14

[Tom Prince [:tomprince]]

Attachment: Bug 1637544: Rename `needs-sccache` to `use-sccache`; r?glandium

I'm going to change this from being autodected, to specified explicitly, and so
use-sccache better captures the meaning.

Comment 15

[Tom Prince [:tomprince]]

Attachment: Bug 1637544: Set `use-sccache` explicitly, rather than based on an sccache toolchain being provided; r?glandium

Comment 16

[Tom Prince [:tomprince]]

Attachment: Bug 1637544: Use sccache on instrumented builds on non-release branches; r?glandium

Comment 17

[Tom Prince [:tomprince]]

This is queued to autoland.

Comment 18

[Sylvestre Ledru [:Sylvestre]]

Many thanks!

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/447fea64b68d
Rename `needs-sccache` to `use-sccache`; r=glandium
https://hg.mozilla.org/integration/autoland/rev/be0717d76643
Set `use-sccache` explicitly, rather than based on an sccache toolchain being provided; r=glandium
https://hg.mozilla.org/integration/autoland/rev/93b955e5c048
Use sccache on instrumented builds on non-release branches; r=glandium

Comment 20

[Alexandru Michis [:malexandru]]

Backed out 3 changesets (Bug 1637544) for causing gecko decision task bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/1d34818fd8317d9f137fef1c04668e0d2e9d152e

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=93b955e5c0485374593b930d074eae73a59f261f&selectedTaskRun=Fa896oyuSx2DoyMFG0BpDA.

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308853934&repo=autoland&lineNumber=214

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1139ed30c6d0
Rename `needs-sccache` to `use-sccache`; r=glandium
https://hg.mozilla.org/integration/autoland/rev/86f49703dec0
Set `use-sccache` explicitly, rather than based on an sccache toolchain being provided; r=glandium
https://hg.mozilla.org/integration/autoland/rev/b20bda11518b
Use sccache on instrumented builds on non-release branches; r=glandium

Comment 22

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1139ed30c6d0
https://hg.mozilla.org/mozilla-central/rev/86f49703dec0
https://hg.mozilla.org/mozilla-central/rev/b20bda11518b

Comment 23

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #26495 (as of Mon, 13 Jul 2020 10:30:01 GMT) ==

Improvements:

55% build times linux64-shippable opt instrumented taskcluster-m5.4xlarge 2,225.72 -> 1,002.70
52% build times osx-shippable opt instrumented taskcluster-m5.4xlarge 2,401.25 -> 1,149.88
49% build times linux64-shippable opt instrumented taskcluster-c5d.4xlarge 2,137.52 -> 1,098.07
47% build times osx-shippable opt instrumented taskcluster-c5.4xlarge 2,312.68 -> 1,225.96
45% build times android-4-0-armv7-api16 pgo instrumented taskcluster-c5d.4xlarge 1,767.90 -> 969.43
42% build times osx-shippable opt instrumented taskcluster-c5d.4xlarge 2,318.09 -> 1,334.99
41% build times android-4-0-armv7-api16 pgo instrumented taskcluster-c5.4xlarge 1,807.32 -> 1,070.22

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26495

Comment 24

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:marco, maybe it's time to close this bug?