1637561 - Use dictionary argument in ResourceWatcher.watch

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau]]

ResourceWatcher.watch interface looks currently like this:
async watch(resources, onAvailable, onDestroyed) {

But, we are talking about exposing a new onUpdated callback (here), and also possibly a new option in order to listen only for "future" resources (here). And who knows if we will start adding yet some others??

It may be great to start using a dictionary argument.

I could think about using either:
async watch(resources, { onAvailable, onDestroyed })
or
async watch({ resources, onAvailable, onDestroyed })
The first better highlight that resources is a mandatory attribute.

This may soon become:
async watch(resources, { onAvailable, onUpdated, onDestroyed, onlyFuture })
or
async watch({ resources, onAvailable, onUpdated, onDestroyed, onlyFuture })

(Flagging in the reserve list as that's not mandarory refactoring)

Comment 1

[Julian Descottes [:jdescottes]]

I like the async watch(resources, { onAvailable, onDestroyed }) option. As you said, it highlights the importance and mandatory nature of resources. onAvailable is also mandatory, but async watch(resources, onAvailable, { onDestroyed, ... }) would not make any sense :)

Comment 2

[Chris Peterson [:cpeterson]]

dt-fission-m2-reserve bugs do not need to block Fission Nightly (M6). For now, let's track them for Fission riding the trains to Beta (M7) so we revisit these bugs before we ship Fission.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

agreed with Comment 2 :)

Comment 4

[Daisuke Akatsuka (:daisuke)]

Okee! And me too!

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1637561: Introduce dictionary argument to 'watch' function.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71f30ecda0be
Introduce dictionary argument to 'watch' function. r=ochameau,nchevobbe

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/71f30ecda0be