Make the startup recorder and browser_startup_syncIPC.js test more reliable
Categories
(Firefox :: General, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(3 files, 1 obsolete file)
We sometimes miss the end of startup as currently there's a race between the 10 idle callbacks at https://searchfox.org/mozilla-central/rev/446160560bf32ebf4cb7c4e25d7386ee22667255/browser/components/tests/startupRecorder.js#178,180 and whatever is happening during actual browser startup. We keep adding more stuff to _scheduleStartupIdleTasks in BrowserGlue.jsm, so 10 idle callbacks might not be enough anymore to capture all of the startup idle tasks.
Assignee | ||
Comment 1•11 months ago
|
||
Looks green on TV on try, except for Windows asan where we have startup hangs that I suspect of being due to startup profiling; I think we should just disable this whole folder of tests for Windows asan.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=81d7ca0083884e2c94fba83559de91aa37c61620
Assignee | ||
Comment 2•11 months ago
|
||
Assignee | ||
Comment 3•11 months ago
|
||
Depends on D75103
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0bc8e4705f31 Make startupRecorder wait until end of browser idle tasks, r=emalysz. https://hg.mozilla.org/integration/autoland/rev/ed3dbaaaf6da Re-enable syncIPC test on Linux, r=emalysz.
Comment 5•11 months ago
|
||
Backed out 4 changesets (bug 1580390, bug 1637603, bug 1629824) for Browser-chrome failures in performance/browser_startup_images.js. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302310802&repo=autoland&lineNumber=16761
Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=7a0696cf87a3256f13dbeddb620ed783f4dbeb90
Backout:
https://hg.mozilla.org/integration/autoland/rev/8714cc14400550c3ef4f69b8b6ef8d844e830a93
Assignee | ||
Comment 6•11 months ago
|
||
Assignee | ||
Comment 7•11 months ago
|
||
(In reply to Dorel Luca [:dluca] from comment #5)
Backed out 4 changesets (bug 1580390, bug 1637603, bug 1629824) for Browser-chrome failures in performance/browser_startup_images.js.
Before my patch, even when "browser.startup.record" wasn't set, we recorded image loads in all startups, which was wasteful, and we never removed the image-drawing
and image-loading
observers.
The browser_startup_images.js test should either set the "browser.startup.record" pref, or a more specific one to only record images. My newer patch picks the latter solution.
Assignee | ||
Comment 8•11 months ago
|
||
Updated•11 months ago
|
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/39d698602851 Make startupRecorder wait until end of browser idle tasks, r=emalysz. https://hg.mozilla.org/integration/autoland/rev/67f178edf1bf Re-enable syncIPC test on Linux, r=emalysz. https://hg.mozilla.org/integration/autoland/rev/2195e7f43611 Extract the startup recording logic for image loading from the rest of startup recorder, r=johannh.
Comment 10•11 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/39d698602851
https://hg.mozilla.org/mozilla-central/rev/67f178edf1bf
https://hg.mozilla.org/mozilla-central/rev/2195e7f43611
Assignee | ||
Updated•11 months ago
|
Description
•