Closed Bug 1637603 Opened 11 months ago Closed 11 months ago

Make the startup recorder and browser_startup_syncIPC.js test more reliable

Categories

(Firefox :: General, task)

task

Tracking

()

RESOLVED FIXED
Firefox 78
Tracking Status
firefox78 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(3 files, 1 obsolete file)

We sometimes miss the end of startup as currently there's a race between the 10 idle callbacks at https://searchfox.org/mozilla-central/rev/446160560bf32ebf4cb7c4e25d7386ee22667255/browser/components/tests/startupRecorder.js#178,180 and whatever is happening during actual browser startup. We keep adding more stuff to _scheduleStartupIdleTasks in BrowserGlue.jsm, so 10 idle callbacks might not be enough anymore to capture all of the startup idle tasks.

Blocks: 1580390

Looks green on TV on try, except for Windows asan where we have startup hangs that I suspect of being due to startup profiling; I think we should just disable this whole folder of tests for Windows asan.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=81d7ca0083884e2c94fba83559de91aa37c61620

Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0bc8e4705f31
Make startupRecorder wait until end of browser idle tasks, r=emalysz.
https://hg.mozilla.org/integration/autoland/rev/ed3dbaaaf6da
Re-enable syncIPC test on Linux, r=emalysz.

(In reply to Dorel Luca [:dluca] from comment #5)

Backed out 4 changesets (bug 1580390, bug 1637603, bug 1629824) for Browser-chrome failures in performance/browser_startup_images.js.

Before my patch, even when "browser.startup.record" wasn't set, we recorded image loads in all startups, which was wasteful, and we never removed the image-drawing and image-loading observers.
The browser_startup_images.js test should either set the "browser.startup.record" pref, or a more specific one to only record images. My newer patch picks the latter solution.

Attachment #9149395 - Attachment is obsolete: true
Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/39d698602851
Make startupRecorder wait until end of browser idle tasks, r=emalysz.
https://hg.mozilla.org/integration/autoland/rev/67f178edf1bf
Re-enable syncIPC test on Linux, r=emalysz.
https://hg.mozilla.org/integration/autoland/rev/2195e7f43611
Extract the startup recording logic for image loading from the rest of startup recorder, r=johannh.
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
Flags: needinfo?(florian)
You need to log in before you can comment on or make changes to this bug.