Closed Bug 1637617 Opened 2 months ago Closed 1 month ago

The "What's New" doorhanger is wrongly dismissed when clicking the left or right borders of the panel

Categories

(Firefox :: Messaging System, defect, P2)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
Firefox 79
Tracking Status
firefox76 --- wontfix
firefox77 --- wontfix
firefox78 --- wontfix
firefox79 --- verified

People

(Reporter: ppop, Assigned: emcminn)

Details

Attachments

(2 files)

Attached image dismiss.gif

[Affected versions]:

  • Firefox Nightly 78.0a1
  • Firefox Beta 77.0b5
  • Firefox Release 76.0.1

[Affected Platforms]:

  • Windows 10 x64
  • macOS 10.15
  • Ubuntu 18.04 x64

[Steps to reproduce]:

  1. Open the browser.
  2. Click the hamburger menu button and click the "What's New" button.
  3. Click on the left or right side border of the doorhanger and observe the behavior.

[Expected result]:

  • The "What's New" doorhanger remains displayed and nothing happens.

[Actual result]:

  • The "What's New" doorhanger is dismissed.

[Notes]:

  • Attached a screen recording of the issue:
Summary: The "What's New" doorhanger is wrongly dismissed when clicking the left and right borders of the panel → The "What's New" doorhanger is wrongly dismissed when clicking the left or right borders of the panel
Assignee: nobody → emcminn
Attachment #9150478 - Attachment description: Bug 1637617 - adjusted message margins to prevent panel closing → Bug 1637617 - Adjusted message margins to prevent panel closing; added panel header to main view panel
Pushed by emcminn@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a76116eb180c
Adjusted message margins to prevent panel closing; added panel header to main view panel r=andreio
Attachment #9150478 - Attachment description: Bug 1637617 - Adjusted message margins to prevent panel closing; added panel header to main view panel → Bug 1637617 - Adjusted message margins to prevent panel closing; added panel header to main view panel & updated fluent strings

Patch updated to fix failures :)

Flags: needinfo?(emcminn)
Pushed by emcminn@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63d2be009e8d
Adjusted message margins to prevent panel closing; added panel header to main view panel & updated fluent strings r=andreio,fluent-reviewers,flod
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79

I have verified that the "What's New Panel" is not dismissed when clicking the right or left borders of the panel using Firefox Nightly 79.0a1 (Build ID:20200604220012) on Windows 10 x64, macOS 10.15, and Ubuntu Linux 18.04.

Status: RESOLVED → VERIFIED

The patch landed in nightly and beta is affected.
:emcminn, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(emcminn)
Flags: needinfo?(emcminn)
You need to log in before you can comment on or make changes to this bug.