1637624 - Refactor nsIFrame::PeekOffset for readability

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

https://searchfox.org/mozilla-central/rev/0688ffdef223dac527c2fcdb25560118c4e4df51/layout/generic/nsFrame.cpp#8852-9207

Currently it has hundreds of lines in a single function, which makes it hard to understand.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1637624 - Part 1: Overload GetFrameFromDirection for nsPeekOffsetStruct

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e27a62f854b2
Part 1: Overload GetFrameFromDirection for nsPeekOffsetStruct r=emilio

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e27a62f854b2

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1637624 - Part 2: Use StaticPrefs for layout.word_select.* r=emilio

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1637624 - Part 3: Merge the description for mSawBeforeType r=emilio

Depends on D83090

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1637624 - Part 4: Merge offsetAdjustment into offset r=emilio

Depends on D83091

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1637624 - Part 5: Use MOZ_TRY r=emilio

Depends on D83092

Comment 8

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1637624 - Part 6: Add SetOutputOffsetFromFrame() r=emilio

Depends on D83093

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1637624 - Part 7: Split PeekOffset switch entries to separate methods r=emilio

Depends on D83094

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/014716df9d1f
Part 2: Use StaticPrefs for layout.word_select.* r=emilio
https://hg.mozilla.org/integration/autoland/rev/e254ee46b023
Part 3: Merge the description for mSawBeforeType r=emilio
https://hg.mozilla.org/integration/autoland/rev/04538c55f37b
Part 4: Merge offsetAdjustment into offset r=emilio
https://hg.mozilla.org/integration/autoland/rev/905dd29d1b3f
Part 5: Use MOZ_TRY r=emilio
https://hg.mozilla.org/integration/autoland/rev/ab48b45d6a56
Part 6: Add SetOutputOffsetFromFrame() r=emilio
https://hg.mozilla.org/integration/autoland/rev/af91f317d081
Part 7: Split PeekOffset switch entries to separate methods r=emilio

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/014716df9d1f
https://hg.mozilla.org/mozilla-central/rev/e254ee46b023
https://hg.mozilla.org/mozilla-central/rev/04538c55f37b
https://hg.mozilla.org/mozilla-central/rev/905dd29d1b3f
https://hg.mozilla.org/mozilla-central/rev/ab48b45d6a56
https://hg.mozilla.org/mozilla-central/rev/af91f317d081