Create a Compatibility actor
Categories
(DevTools :: Inspector: Rules, task, P3)
Tracking
(firefox79 fixed)
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: mtigley, Assigned: lelouch.cpp)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Create another property called includeCompatiblityIssues
on the options argument for PageStyleActor’s getApplied
That way, the computation for CSS issues will be in one place rather than duplicating logic that’s in the Compatibility panel’s _getNodeIssues
Reporter | ||
Comment 1•5 years ago
|
||
Additional items this issue should address, but we can separate these as separate patches.
• Refactor _getNodesIssues
to use the new list of CSS compat warnings returned by getApplied
• Access the target browsers list on the server-side (or pass this is an option from the client).
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 2•5 years ago
|
||
Based on discussions in the public Slack channel, we'll be creating a Compatibility Actor for use by both the Compatibility and CSS Rules panel. For now, we'll only worry about adding a methods that gets the CSS browser compat warnings.
This patch creates a CompatibilityActor and exposes it using
the IspectorActor via the InspectorFront.
To check the correctness this patch replaces the call to the
MDNCompatibility with the call to compatibility.getNodeCssIssues
which is a direct encapsulation for the pageStyle.getApplied() +
MDNCompatibility call.
Current Status:
The compatibility actor works only when:
- The issues is text-style-adjust
- The element with the issus is in focus
- All CSS issues panel is always empty
To test the above behavior one can visit https://duckduckgo.com/
and focus on the out HTML element in the inspector panel
Updated•5 years ago
|
Added browser test for CompatibilityActor to check consistency and
correctness.
Thse test include:
- Test for no issue
- Test for simple issue
- Test for invalid CSS rule
- Test for aliases
- Test for browser specific issues
- Test for multiple issues for same element
Depends on D77060
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bbe4cf873819
https://hg.mozilla.org/mozilla-central/rev/62d50af432bb
Description
•