Closed Bug 1637634 Opened 2 months ago Closed 1 month ago

IsOnContentBlockingAllowList doesn't handle redirect

Categories

(Core :: Privacy: Anti-Tracking, defect)

defect

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: dimi, Assigned: dimi)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently we update mIsOnContentBlockingAllowList flag in DocumentLoadListener when loading a top-level channel[1].
However, we don't update the flag when a redirect occurs, we should fix this.

[1] https://searchfox.org/mozilla-central/rev/0688ffdef223dac527c2fcdb25560118c4e4df51/netwerk/ipc/DocumentLoadListener.cpp#453

Assignee: nobody → dlee
Status: NEW → ASSIGNED
Pushed by dlee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/efd4bcfa61dc
Update IsOnContentBlockingAllowList in nsHttpChannel::AsyncOpen r=timhuang,necko-reviewers
Backout by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dbfad8ecbc50
Backed out changeset efd4bcfa61dc for causing failures in ContentBlockingAllowList.cpp
Flags: needinfo?(dlee)
Pushed by dlee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b42b355fc457
Update IsOnContentBlockingAllowList in nsHttpChannel::AsyncOpen r=timhuang,necko-reviewers

Backed out for crashes on UpdateIsOnContentBlockingAllowList

backout: https://hg.mozilla.org/integration/autoland/rev/14539eeabd2bb8d2cbb5764e300ab94d762a5b71

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=xpcshell&revision=b42b355fc457633c75fa4e950cb992acca57a64a

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303678274&repo=autoland&lineNumber=2956

[task 2020-05-25T19:19:26.529Z] 19:19:26 INFO - TEST-START | dom/security/test/unit/test_csp_upgrade_insecure_request_header.js
[task 2020-05-25T19:19:26.792Z] 19:19:26 WARNING - TEST-UNEXPECTED-FAIL | dom/security/test/unit/test_csp_upgrade_insecure_request_header.js | xpcshell return code: -11
[task 2020-05-25T19:19:26.793Z] 19:19:26 INFO - TEST-INFO took 259ms
[task 2020-05-25T19:19:26.793Z] 19:19:26 INFO - >>>>>>>
[task 2020-05-25T19:19:26.793Z] 19:19:26 INFO - PID 18906 | [18906, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp, line 2924
[task 2020-05-25T19:19:26.793Z] 19:19:26 INFO - PID 18906 | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2020-05-25T19:19:26.795Z] 19:19:26 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2020-05-25T19:19:26.797Z] 19:19:26 INFO - PID 18906 | [18906, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, kKnownEsrVersion) failed with result 0x80004002 (NS_NOINTERFACE): file /builds/worker/checkouts/gecko/toolkit/components/resistfingerprinting/nsRFPService.cpp, line 673
[task 2020-05-25T19:19:26.798Z] 19:19:26 INFO - PID 18906 | [18906, Main Thread] WARNING: NSS will be initialized without a profile directory. Some things may not work as expected.: file /builds/worker/checkouts/gecko/security/manager/ssl/nsNSSComponent.cpp, line 1622
[task 2020-05-25T19:19:26.799Z] 19:19:26 INFO - PID 18906 | [18906, Cache2 I/O] WARNING: Forcing memory-only entry since CacheFileIOManager doesn't have mCacheDirectory.: file /builds/worker/checkouts/gecko/netwerk/cache2/CacheFile.cpp, line 516
[task 2020-05-25T19:19:26.801Z] 19:19:26 INFO - (xpcshell/head.js) | test pending (2)
[task 2020-05-25T19:19:26.802Z] 19:19:26 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2020-05-25T19:19:26.803Z] 19:19:26 INFO - running event loop
[task 2020-05-25T19:19:26.804Z] 19:19:26 INFO - PID 18906 | [18906, Main Thread] WARNING: Could not get the program name for a cubeb stream.: 'NS_SUCCEEDED(rv)', file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp, line 375
[task 2020-05-25T19:19:26.805Z] 19:19:26 INFO - "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
[task 2020-05-25T19:19:26.806Z] 19:19:26 INFO - TEST-PASS | dom/security/test/unit/test_csp_upgrade_insecure_request_header.js | onStopRequest - [onStopRequest : 63] false == false
[task 2020-05-25T19:19:26.807Z] 19:19:26 INFO - PID 18906 | Assertion failure: mRawPtr != nullptr (You can't dereference a NULL RefPtr with operator->().), at /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h:315
[task 2020-05-25T19:19:26.812Z] 19:19:26 INFO - Initializing stack-fixing for the first stack frame, this may take a while...

Flags: needinfo?(dlee)
Pushed by dlee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b4f883d57ca6
Update IsOnContentBlockingAllowList in nsHttpChannel::AsyncOpen r=timhuang,necko-reviewers
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
Flags: needinfo?(dlee)
You need to log in before you can comment on or make changes to this bug.