1637691 - Disable WebRender for ESR 78

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, task, P2)

Description

[Jessie [:jbonisteel] pls NI]

We will want to disable WebRender for ESR 78. In chatting with RyanVM his direction is to:

"land the patch on the ESR78 some time late in the next cycle probably (after the branch has been created)"

Comment 1

[Jessie [:jbonisteel] pls NI]

NI-ing you to get this on your radar for early Beta

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Do we want to force disable this (e.g. can't flip a pref to turn it on), or do we just want to not enable it?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

This is what we did last time: https://hg.mozilla.org/releases/mozilla-esr68/rev/ac28518e5a4e56722c3b7b9f97a59ed83f10c5d6
It seemed to work fine.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)

This is what we did last time: https://hg.mozilla.org/releases/mozilla-esr68/rev/ac28518e5a4e56722c3b7b9f97a59ed83f10c5d6
It seemed to work fine.

Okay, that allowed enabling via pref still. I will do the same.

Comment 5

[[:fabrice] Fabrice Desré]

Does that mean that there will be no webrender fixes backported to ESR 78?

Comment 6

[Jessie [:jbonisteel] pls NI]

That is indeed what that means. We aren't quite ready yet to support WebRender in ESR.

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1637691 - Block WebRender on ESR 78.

Comment 8

[Andrew Osmond [:aosmond] (he/him)]

Leaving my needinfo up since we can't request esr78 uplift yet. I based the patch on mozilla-beta, because mozilla-esr78 is quite stale.

Comment 9

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9155744 [details]
Bug 1637691 - Block WebRender on ESR 78.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: We do not want to support WebRender in the next ESR iteration.
• User impact if declined: Some users will get WebRender.
• Fix Landed on Version: Uplift for 78 ESR only
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We continue to ship non-WebRender for a majority of users. It remains a well tested code path.

I would request QA verification on Windows with WebRender supported hardware on release once a build is available. We should not see WebRender on the ESR branch, but should see it on 78 beta/release.

• String or UUID changes made by this patch: N/A

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 9155744 [details]
Bug 1637691 - Block WebRender on ESR 78.

approved for 78.0esr

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/53bc9ff61344

Comment 12

[Ryan VanderMeulen [:RyanVM]]

QA should definitely verify this.

Comment 13

[Cristian Fogel [:cfogel]]

Verified with 78.2.0esr on Windows 10, macOS 10.15, Ubuntu 20.