1637748 - Optimize StringCharCodeAt in CacheIR

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P1)

Description

[Tom S [:evilpie]]

I needed some simple CacheIR stub for testing the transpilation of Call stubs. Sadly all the existing "special cased natives" are kind of complicated. This should also be useful for octane-mandreel perf when we get there.

I also added some cleanup.

Comment 1

[Tom S [:evilpie]]

Attachment: Bug 1637748 - Use the InlinableNative enum instead of JSNative pointers. r?iain

Comment 2

[Tom S [:evilpie]]

Attachment: Bug 1637748 - Add emitNativeCalleeGuard helper. r?iain

Depends on D75194

Comment 3

[Tom S [:evilpie]]

Attachment: Bug 1637748 - Optimize StringChar(Code)At in CacheIR. r?iain

Depends on D75195

Comment 4

[Tom S [:evilpie]]

Attachment: Bug 1637748 - Dont guard on the argc, which is always constant per PC. r?iain

Technically this is not needed yet, because we only use this function in cases when pc == JSOp::Call(IgnoreRv),
but I think this a nicer abstraction for the future.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ae0a2e14c02
Use the  InlinableNative enum instead of JSNative pointers. r=iain
https://hg.mozilla.org/integration/autoland/rev/0a3b09709cc0
Add emitNativeCalleeGuard helper. r=iain
https://hg.mozilla.org/integration/autoland/rev/42c078bfda8c
Optimize StringChar(Code)At in CacheIR. r=iain
https://hg.mozilla.org/integration/autoland/rev/3c2afd69bfd5
Dont guard on the argc, which is always constant per PC. r=iain

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7ae0a2e14c02
https://hg.mozilla.org/mozilla-central/rev/0a3b09709cc0
https://hg.mozilla.org/mozilla-central/rev/42c078bfda8c
https://hg.mozilla.org/mozilla-central/rev/3c2afd69bfd5