Closed Bug 1637756 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 23577 - [Image-Orientation] Have ImageBitmap.width and .height report oriented sizes

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23577 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23577
Details from upstream follow.

Stephen Chenney <schenney@chromium.org> wrote:

[Image-Orientation] Have ImageBitmap.width and .height report oriented sizes

ImageBitmap has only width and height properties, forcing us to choose
one of oriented or unoriented values to report. Given oriented usage is
now the default, we'll change the reported sizes to match the used sizes.

A spec issue will be raised to add naturalWidth or orientedWidth so
that developers can get the data they want.

Also fix a broken path in drawImage-with-src-rect-ref.html

Bug: 1082451
Change-Id: I4dd59766769bbb7175d8216845f19f9122129e16
Reviewed-on: https://chromium-review.googlesource.com/2198654
WPT-Export-Revision: 58623941258bc5ec5388b2c0c152cb5ce4c35450

PR 23577 applied with additional changes from upstream: 4d413415dd8c6a0dc18d173071525dc0d12b11a6, 9d1c70169bf38321d230e3ddd1daffc099002452
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 1
FAIL: 1[Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt] 2[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub]

Chrome

FAIL: 2

Safari

FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/canvas/element/drawing-images-to-the-canvas/image-orientation/drawImage-from-blob.tentative.html: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], PASS [Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt] (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/drawing-images-to-the-canvas/image-orientation/drawImage-with-src-rect.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15cc0dcc40d7
[wpt PR 23577] - [Image-Orientation] Have ImageBitmap.width and .height report oriented sizes, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.