1637822 - [wpt-sync] Sync PR 23585 - Add inset inline properties tests for dialog centering tests

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23585 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23585
Details from upstream follow.

sefeng <[e-mail]> wrote:

Add inset inline properties tests for dialog centering tests

Dialog supposes to use inset inline properties for centering, based on it's writing mode. This PR adds tests to test it.

This is also going to address https://github.com/whatwg/html/pull/5532

cc @domenic

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=72c88940254f3a503e3e41312611996a755cdb6c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 72 tests

Status Summary

Firefox

OK : 1
PASS: 1[GitHub] 72[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 14

Chrome

OK : 1
PASS: 7
FAIL: 8

Safari

OK : 1
FAIL: 15

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/interactive-elements/the-dialog-element/centering.html
horizontal-tb (container vertical-rl) (dialog horizontal-tb): tall viewport: FAIL (Chrome: FAIL, Safari: FAIL)
vertical-rl (dialog horizontal-tb): tall viewport: FAIL (Chrome: FAIL, Safari: FAIL)
vertical-rl (container horizontal-tb) (dialog vertical-rl): tall viewport: FAIL (Chrome: FAIL, Safari: FAIL)
vertical-lr (dialog horizontal-tb): tall viewport: FAIL (Chrome: FAIL, Safari: FAIL)
horizontal-tb (container vertical-rl): tall viewport: FAIL (Chrome: FAIL, Safari: FAIL)
horizontal-tb: tall viewport: FAIL (Chrome: PASS, Safari: FAIL)
vertical-rl (container horizontal-tb): tall viewport: FAIL (Chrome: PASS, Safari: FAIL)
horizontal-tb: square viewport: FAIL (Chrome: PASS, Safari: FAIL)
horizontal-tb: wide viewport: FAIL (Chrome: PASS, Safari: FAIL)
horizontal-tb: dialog and viewport match: FAIL (Chrome: PASS, Safari: FAIL)
vertical-lr: dialog bigger than viewport: FAIL (Chrome: FAIL, Safari: FAIL)
vertical-rl: tall viewport: FAIL (Chrome: FAIL, Safari: FAIL)
horizontal-tb: dialog bigger than viewport: FAIL (Chrome: PASS, Safari: FAIL)
vertical-lr: tall viewport: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c2719339331
[wpt PR 23585] - Add inset inline properties tests for dialog centering tests, a=testonly

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5c2719339331