Closed Bug 1637839 Opened 5 years ago Closed 2 years ago

Network.responseReceived should be emitted after requestfinished

Categories

(Remote Protocol :: CDP, defect, P2)

Product:
Remote Protocol
Component:
CDP
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INACTIVE

People

(Reporter: impossibus, Unassigned)

References

Details

(Whiteboard: [puppeteer-beta2-mvp])

The initial implementation handles our NetworkObserver's response event, but waiting until requestfinished (when the response body is received) is probably what is expected instead. We should be able to return data the event that way, as well, such as encodedDataLength.

Might be unrelated here but we also miss to send out the Network.requestWillBeSent event. Maybe worth another bug I assume.

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #1)

Might be unrelated here but we also miss to send out the Network.requestWillBeSent event. Maybe worth another bug I assume.

Are you thinking of a specific example where it's missing? In general we do send requestWillBeSent appropriately, so I'm not sure what you mean here.

Flags: needinfo?(hskupin)

The situation where I have seen this was actually for data URIs. See attachment 9148032 [details].

Flags: needinfo?(hskupin)
Whiteboard: [puppeteer-beta-reserve] → [puppeteer-beta2-mvp]
Component: CDP: Network → CDP

We are currently not working on CDP.

Severity: -- → S3
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.