1637865 - Clean up methods handling whitespace sequence in `WSRunObject`

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P3)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1637865 - part 1: Clean up `WSRunObject::ReplacePreviousNBSPIfUnnecessary()` and `WSRunObject::CheckLeadingNBSP()` r=m_kato!

They are complicated because of not using early-return style.

Depends on D75471

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1637865 - part 2: Rename `spaceNBSP` in `WSRUnObject::CheckTrailingNBSPOfRun()` r=m_kato!

Depends on D75472

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1637865 - part 3: Rename `leftCheck` in `WSRunObject::CheckTrailingNBSPOfRun()` r=m_kato!

Then, the last if block runs obviously only when the preceding if block
runs. Therefore, this patch moves it.

Depends on D75473

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1637865 - part 4: Rename `rightCheck` in `WSRunObject::CheckTrailingNBSPOfRun()` r=m_kato!

Although the new name is not true when neither
maybeNBSPFollowingVisibleContent nor isPreviousCharASCIIWhitespace is true.

Depends on D75474

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1637865 - part 5: Clean up `WSRunObject::CheckTrailingNBSPOfRun()` r=m_kato!

This patch makes it use early-return style and adds some comments. Its behavior
should be changed as soon as possible for web-compat. Therefore, I don't
write current behavior as comment at declaration.

Depends on D75475

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83ac1ca91ced
part 1: Clean up `WSRunObject::ReplacePreviousNBSPIfUnnecessary()` and `WSRunObject::CheckLeadingNBSP()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/93b022e2a192
part 2: Rename `spaceNBSP` in `WSRUnObject::CheckTrailingNBSPOfRun()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/8f39b27ae9b2
part 3: Rename `leftCheck` in `WSRunObject::CheckTrailingNBSPOfRun()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/53c9b3b340e6
part 4: Rename `rightCheck` in `WSRunObject::CheckTrailingNBSPOfRun()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/89323728b4a7
part 5: Clean up `WSRunObject::CheckTrailingNBSPOfRun()` r=m_kato

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/83ac1ca91ced
https://hg.mozilla.org/mozilla-central/rev/93b022e2a192
https://hg.mozilla.org/mozilla-central/rev/8f39b27ae9b2
https://hg.mozilla.org/mozilla-central/rev/53c9b3b340e6
https://hg.mozilla.org/mozilla-central/rev/89323728b4a7