Closed Bug 1637922 Opened 3 years ago Closed 1 year ago

Consider disabling dom.netinfo.enabled on mobile


(GeckoView :: General, defect, P3)



(Webcompat Priority:P1, firefox99 fixed)

99 Branch
Webcompat Priority P1
Tracking Status
firefox99 --- fixed


(Reporter: annevk, Assigned: karlcow)


(Regressed 1 open bug)


(Keywords: dev-doc-complete)


(5 files)

This is not a feature we ship on Firefox desktop and we don't plan to as we think it exposes too much user information. It would be good if we did the same on mobile for the same reason.

See bug 1057169.

A follow-up bug could then be used to remove the code once some time has passed.

Note that we need to keep it on b2g, so disabling is fine but not removing the code.

Severity: -- → S4
Priority: -- → P3

So this probably creates a webcompat issue on Firefox Android for CDN shopify theming.

Webcompat Priority: --- → P1

If deactivating it creates more webcompat issues than solving this one, the webcompat team could still create a site intervention targeting the CDN of shopify.

Assignee: nobody → kdubost

Depends on D126442

OS: All → Android
Attachment #9242623 - Attachment description: Bug 1637922. Disables for serviceworker tests. r=annevk → Bug 1637922. Disables netinfo in some tests. r=annevk

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:karlcow, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(kdubost)
Flags: needinfo?(annevk)

Hmmm Thomas do you think this is ready to land?

Flags: needinfo?(kdubost) → needinfo?(twisniewski)
Flags: needinfo?(annevk)

@karlcow, based on what I'm seeing here, I don't think there's anything left to do, so it seems like we could land it.

Flags: needinfo?(twisniewski)

You have the landing power. :)

Flags: needinfo?(twisniewski)
Pushed by
Disables dom.netinfo.enabled everywhere. r=annevk
Switches to disable everywhere for netinfo. r=annevk,webidl,peterv
Disables netinfo in some tests. r=annevk,webidl,peterv
Flags: needinfo?(kdubost)

I will be working on it tomorrow. Thanks james for trying to land it.

Flags: needinfo?(twisniewski)

The failures are:

[task 2022-02-08T15:47:53.447Z] 15:47:53  WARNING -  TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces.html | false: NetworkInformation should  be defined on self
[task 2022-02-08T15:47:53.447Z] 15:47:53     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2022-02-08T15:47:53.447Z] 15:47:53     INFO -      workerTestExec/worker.onmessage@dom/workers/test/worker_driver.js:35:9

TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces.html | 1 === 0: The following interface(s) are not enumerated: NetworkInformation
[task 2022-02-08T15:47:53.448Z] 15:47:53     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2022-02-08T15:47:53.448Z] 15:47:53     INFO -      workerTestExec/worker.onmessage@dom/workers/test/worker_driver.js:35:9

So hopefully we should just need to change the test expectation here to "disabled":

Thomas, could you review this and try to land again?


Flags: needinfo?(twisniewski)
Pushed by
Disables dom.netinfo.enabled everywhere. r=annevk
Switches to disable everywhere for netinfo. r=annevk,webidl,peterv
Disables netinfo in some tests. r=annevk,webidl,peterv
Disables for serviceworker tests. r=twisniewski
Regressions: 1755852
Blocks: 1737852
See Also: → 1755948
See Also: → 1756692

FF99 docs work for this can be tracked in

For my information, has the Network Information API been formally deprecated/removed from the standards track? It looks to me like this is not the case - though the API is being revisited in specification to address issues like the ones that required the feature be disabled.

It's not standards track at the moment, is it? It's just a WICG document, not a deliverable of a W3C WG, WHATWG, or IETF WG.

Thanks Anne - you're right - the compat data says it is on "standards track" but the spec is indeed WICG. I'll query with the compat people as to why.

Hi @Anne,
FYI only, the comment from the browser compat team was that:

WICG is a gray area in terms of whether it's considered standard track or not, depending on who you ask. In BCD, we have treated WICG as if it is a standard track, and WICG spec URLs are included in w3c/browser-specs

That is all I personally needed.

To be clear, Mozilla does not consider WICG standards track.

Yes - for anyone else coming to this discussion the short version is that the standard_track key is in the data is a misleading name. All it means is that there is a specification associated with the feature.
We're hoping to get rid of that key altogether:

deactivating it solved an issue and made the website working.

Flags: needinfo?(twisniewski)
You need to log in before you can comment on or make changes to this bug.