Consider disabling dom.netinfo.enabled on mobile
Categories
(GeckoView :: General, defect, P3)
Tracking
(Webcompat Priority:P1, firefox99 fixed)
Tracking | Status | |
---|---|---|
firefox99 | --- | fixed |
People
(Reporter: annevk, Assigned: karlcow)
References
(Regressed 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(5 files)
This is not a feature we ship on Firefox desktop and we don't plan to as we think it exposes too much user information. It would be good if we did the same on mobile for the same reason.
See bug 1057169.
A follow-up bug could then be used to remove the code once some time has passed.
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Note that we need to keep it on b2g, so disabling is fine but not removing the code.
Updated•5 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
So this probably creates a webcompat issue on Firefox Android for CDN shopify theming.
https://webcompat.com/issues/67436
Assignee | ||
Comment 3•3 years ago
|
||
If deactivating it creates more webcompat issues than solving this one, the webcompat team could still create a site intervention targeting the CDN of shopify.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 4•3 years ago
|
||
Assignee | ||
Comment 5•3 years ago
|
||
Intent to unship.
https://groups.google.com/a/mozilla.org/g/dev-platform/c/u1QiOGUIUfk
Assignee | ||
Comment 6•3 years ago
|
||
Assignee | ||
Comment 7•3 years ago
|
||
Depends on D126431
Assignee | ||
Comment 8•3 years ago
|
||
Depends on D126442
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Comment 9•3 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:karlcow, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 10•3 years ago
|
||
Hmmm Thomas do you think this is ready to land?
Reporter | ||
Updated•3 years ago
|
Comment 11•3 years ago
|
||
@karlcow, based on what I'm seeing here, I don't think there's anything left to do, so it seems like we could land it.
Comment 13•3 years ago
|
||
Comment 14•3 years ago
|
||
Backed out for causing failures on test_worker_interfaces.html
Backout link: https://hg.mozilla.org/integration/autoland/rev/407cf6c951c48b80f7851134504b6e6ede964ed3
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=367078055&repo=autoland&lineNumber=2967
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 15•3 years ago
|
||
I will be working on it tomorrow. Thanks james for trying to land it.
Comment 16•3 years ago
|
||
The failures are:
[task 2022-02-08T15:47:53.447Z] 15:47:53 WARNING - TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces.html | false: NetworkInformation should be defined on self
[task 2022-02-08T15:47:53.447Z] 15:47:53 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2022-02-08T15:47:53.447Z] 15:47:53 INFO - workerTestExec/worker.onmessage@dom/workers/test/worker_driver.js:35:9
TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces.html | 1 === 0: The following interface(s) are not enumerated: NetworkInformation
[task 2022-02-08T15:47:53.448Z] 15:47:53 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2022-02-08T15:47:53.448Z] 15:47:53 INFO - workerTestExec/worker.onmessage@dom/workers/test/worker_driver.js:35:9
So hopefully we should just need to change the test expectation here to "disabled": https://searchfox.org/mozilla-central/source/dom/workers/test/test_worker_interfaces.js#228
Assignee | ||
Comment 17•3 years ago
|
||
Depends on D126447
Assignee | ||
Comment 18•3 years ago
|
||
Thomas, could you review this and try to land again?
https://phabricator.services.mozilla.com/D138398
Thanks.
Comment 19•3 years ago
|
||
Comment 20•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/85a5290f71e4
https://hg.mozilla.org/mozilla-central/rev/cda9709db315
https://hg.mozilla.org/mozilla-central/rev/38737ed32dc1
https://hg.mozilla.org/mozilla-central/rev/4a3025a77f16
Comment 21•3 years ago
|
||
FF99 docs work for this can be tracked in https://github.com/mdn/content/issues/13840#issuecomment-1066255533
For my information, has the Network Information API been formally deprecated/removed from the standards track? It looks to me like this is not the case - though the API is being revisited in specification to address issues like the ones that required the feature be disabled.
Reporter | ||
Comment 22•3 years ago
|
||
It's not standards track at the moment, is it? It's just a WICG document, not a deliverable of a W3C WG, WHATWG, or IETF WG.
Comment 23•3 years ago
|
||
Thanks Anne - you're right - the compat data says it is on "standards track" but the spec is indeed WICG. I'll query with the compat people as to why.
Comment 24•3 years ago
|
||
Hi @Anne,
FYI only, the comment from the browser compat team was that:
WICG is a gray area in terms of whether it's considered standard track or not, depending on who you ask. In BCD, we have treated WICG as if it is a standard track, and WICG spec URLs are included in w3c/browser-specs
That is all I personally needed.
Reporter | ||
Comment 25•3 years ago
|
||
To be clear, Mozilla does not consider WICG standards track.
Comment 26•3 years ago
|
||
Yes - for anyone else coming to this discussion the short version is that the standard_track
key is in the data is a misleading name. All it means is that there is a specification associated with the feature.
We're hoping to get rid of that key altogether: https://github.com/mdn/browser-compat-data/issues/12685
Assignee | ||
Comment 27•3 years ago
|
||
For https://github.com/webcompat/web-bugs/issues/95799
deactivating it solved an issue and made the website working.
Updated•2 years ago
|
Description
•