1637993 - Buttons in reader view "type controls" popover are sensitive to user input even when user input is not available

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect, P5)

Description

[Asif Youssuff]

1. Go to https://getpocket.com/explore/item/who-still-buys-wite-out-and-why
2. Enable reader view
3. enable dark view
4. click any of increase/decrease font size, increase/decrease content width, and increase/decrease line height until one can't change the value any more (min/max)
5. hover over/click on any of increase/decrease font size, increase/decrease content width, and increase/decrease line height where you can no longer change the value

What happens:

The control changes on hover, items are clickable.

Expected result:

Buttons that can no longer be interacted with should not have a hover action and should be insensitive to user input. The forward button in Firefox when there are no pages in the forward stack is a good example.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:yoasif, if you think that's a regression, then could you try to find a regression range in using for example mozregression?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1637993 - The buttons in the reader mode controls should not show hover/active state when they are disabled. r?gijs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e60f20e0b47
The buttons in the reader mode controls should not show hover/active state when they are disabled. r=Gijs

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4e60f20e0b47