1637998 - Community-oriented changes to gfx/wgpu

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, task, P3)

Description

[Dzmitry Malyshau [:kvark]]

This is a catch-all bug for all the changes to gfx/wgpu that do not affect Gecko as the product, but are required for the use of wgpu on native by the community. These may include:

• readme/CI/standalone configuration changes
• swapchain, surface, and presentation changes (Gecko isn't using it today)
• multi-threading changes (Gecko runs wgpu server in a single thread atm)

Some of these may become relevant soon, for example if we decide to switch to native presentation in full-screen mode of WebGPU in Firefox. Or if we start multi-threading on the server side.

Comment 1

[Dzmitry Malyshau [:kvark]]

Attachment: Improve wgpu assertion errors

this improves the assertion messages, adds issue templates, and implements From<TextureFormat> for TextureComponentType.

Comment 2

[Dzmitry Malyshau [:kvark]]

Attachment: Fix wgpu swapchain cleanup on exit

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/759d1658e2b3
Improve wgpu assertion errors r=groves

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/094ea115f330
Fix wgpu swapchain cleanup on exit r=groves

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/759d1658e2b3
https://hg.mozilla.org/mozilla-central/rev/094ea115f330

Comment 6

[Dzmitry Malyshau [:kvark]]

Attachment: wgpu create_surface refactor

just reducing some code

Comment 7

[Dzmitry Malyshau [:kvark]]

Attachment: Make wgpu pass destruction more explicit

The old way of calling into_vec on destruction was awkward

Comment 8

[Dzmitry Malyshau [:kvark]]

Attachment: Fix multi-threaded cleanup of wgpu command pools

Comment 9

[Dzmitry Malyshau [:kvark]]

Attachment: Hook up loom for concurrency testingting of wgpu

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7e2f93d1277
wgpu create_surface refactor r=groves

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ce147d84c8f
Make wgpu pass destruction more explicit r=groves

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a98a0b710cf
Hook up loom for concurrency testingting of wgpu r=groves

Comment 13

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b7e2f93d1277
https://hg.mozilla.org/mozilla-central/rev/7ce147d84c8f
https://hg.mozilla.org/mozilla-central/rev/3a98a0b710cf

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22095a0b7dc6
Fix multi-threaded cleanup of wgpu command pools r=groves

Comment 15

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/22095a0b7dc6

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:kvark, maybe it's time to close this bug?

Comment 17

[Dzmitry Malyshau [:kvark]]

Still ongoing

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:kvark, maybe it's time to close this bug?

Comment 19

[Dzmitry Malyshau [:kvark]]

This is meant to be perpetually open

Comment 20

[Dzmitry Malyshau [:kvark]]

We aren't using M-C as upstream for wgpu (any more)