Closed
Bug 1638060
Opened 5 years ago
Closed 5 years ago
Revisit interface of mozfile
Categories
(Firefox Build System :: General, task)
Firefox Build System
General
Tracking
(firefox78 fixed)
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: rstewart, Assigned: rstewart)
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•5 years ago
|
Summary: Revisit interface of mozpack → Revisit interface of mozfile
|
|
Assignee | |
Comment 1•5 years ago
|
||
At the beginning of the Python 3 migration (circa bug 1602540), we made an update to the interface of mozpack/files.py in the direction of aligning with Python 3's built-in file support; namely, that opening a file in text mode returns a stream of str (text), and that opening a file in binary mode returns a stream of bytes. This was deemed to be more trouble than it was worth. This patch undoes all of those changes to the interface in favor of moving back to the Python 2 style, where all files are bytestreams.
Pushed by rstewart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/327c6c5acdbc
Standardize interface of `mozfile` classes as `bytes`-based streams r=glandium
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•