1638064 - Sort out use of toolkit.cosmeticAnimations.enabled pref in CFRPageActions.jsm

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Dão Gottwald [:dao]]

toolkit.cosmeticAnimations.enabled is going away. CFRPageActions.jsm should either obey prefers-reduced-motion or remove the ability to disable animations. I'm not sure how to test this feature and what happens with the animation disabled...

Comment 1

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [::dao] from comment #0)

I'm not sure how to test this feature and what happens with the animation disabled...

Apparently resource://activity-stream/data/content/assets/cfr_pinnedtab_static.png is used then but that doesn't seem very informative. What exactly is the idea here?

Comment 2

[Andrei Oprea [:andreio]]

Based on the pref we toggle between [e-mail] and cfr_pinnedtab_static.png (both in browser/components/newtab/data/content/assets).
We can switch it to use prefers-reduced-motion instead. Does the tracking flag for 78 mean the pref is going away in 78?

Comment 3

[Dão Gottwald [:dao]]

(In reply to Andrei Oprea [:andreio] from comment #2)

We can switch it to use prefers-reduced-motion instead. Does the tracking flag for 78 mean the pref is going away in 78?

It's basically dead at this point. Only CFRPageActions.jsm and alert.js still read it.

Comment 4

[Emily McMinn :emcminn]

Attachment: Bug 1638064 - Removed toolkit.cosmeticAnimations.enabled pref and replaced it with "prefers-reduced-motion" in CFRPageActions

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/124a0e45acf2
Removed toolkit.cosmeticAnimations.enabled pref and replaced it with "prefers-reduced-motion" in CFRPageActions r=dao

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/124a0e45acf2