1638130 - [Wayland] Fails to build with libc++ due to missing #include <vector>

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Jan Beich]

libc++ unlike libstdc++ doesn't bootleg <vector> via <algorithm> but bug 1635362 moved the include to widget/gtk/MozContainer.h which doesn't seem to use std::vector.

$ c++ --version
FreeBSD clang version 10.0.0 ([e-mail]:llvm/llvm-project.git llvmorg-10.0.0-0-gd32170dbd5b)
Target: x86_64-unknown-freebsd13.0
Thread model: posix
InstalledDir: /usr/bin

$ ./mach build
[...]
In file included from widget/gtk/WaylandVsyncSource.cpp:9:
In file included from widget/gtk/WaylandVsyncSource.h:12:
In file included from widget/gtk/MozContainer.h:12:
widget/gtk/MozContainerWayland.h:45:42: error: implicit instantiation of undefined template
      'std::__1::vector<std::__1::function<void ()>, std::__1::allocator<std::__1::function<void ()> > >'
  std::vector<std::function<void(void)>> initial_draw_cbs;
                                         ^
/usr/include/c++/v1/iosfwd:216:28: note: template is declared here
class _LIBCPP_TEMPLATE_VIS vector;
                           ^
1 error generated.

# Let's add #error to figure out why GCC/libstdc++ is not affected
In file included from objdir/dist/system_wrappers/vector:3,
                 from objdir/dist/stl_wrappers/vector:52,
                 from /usr/local/lib/gcc9/include/c++/functional:62,
                 from objdir/dist/system_wrappers/functional:3,
                 from objdir/dist/stl_wrappers/functional:52,
                 from /usr/local/lib/gcc9/include/c++/pstl/glue_algorithm_defs.h:13,
                 from /usr/local/lib/gcc9/include/c++/algorithm:71,
                 from objdir/dist/system_wrappers/algorithm:3,
                 from objdir/dist/stl_wrappers/algorithm:52,
                 from objdir/dist/include/mozilla/Span.h:25,
                 from objdir/dist/include/mozilla/DbgMacro.h:13,
                 from objdir/dist/include/mozilla/RefPtr.h:13,
                 from widget/gtk/WaylandVsyncSource.h:9,
                 from widget/gtk/WaylandVsyncSource.cpp:9:
/usr/local/lib/gcc9/include/c++/vector:59:2: error: #error bootlegging test
   59 | #error bootlegging test
      |  ^~~~~

Comment 1

[Jan Beich]

Attachment: fix

(Sorry, I can't submit on Phabricator due to bug 1536716.)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d2f47d66128057b24ab0174034af08ae4b5ec85

Comment 2

[Julien Cristau [:jcristau]]

Attachment: Bug 1638130 - Move <vector> where std::vector moved after bug 1635362. r?stransky

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a2daf926176
Move <vector> where std::vector moved after bug 1635362. r=stransky

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3a2daf926176