1638151 - Failure to generate event getter code for nullable sequences

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), defect)

Description

[[:fabrice] Fabrice Desré]

Sincehttps://bugzilla.mozilla.org/show_bug.cgi?id=1628692 landed (including the codegen change at https://hg.mozilla.org/integration/autoland/rev/93b096e2d3da) we fail to build the bindings for https://hg.mozilla.org/projects/kaios/file/tip/dom/webidl/CameraFacesDetectedEvent.webidl

 0:11.07 In file included from UnifiedBindings4.cpp:392:                                                                                                                                           
 0:11.07 /media/external/dev/gecko-dev/obj-b2g-qm215/dom/bindings/CameraFacesDetectedEvent.cpp:90:20: error: no member named 'Clone' in 'mozilla::dom::Nullable<nsTArray<RefPtr<mozilla::dom::DOMCa
meraDetectedFace> > >'                                                                                                                                                                             
 0:11.07   aRetVal = mFaces.Clone();                                                                                                                                                               
 0:11.07             ~~~~~~ ^         

That's not so surprising since Nullable doesn't have a Clone() method. I'm not sure what the best way forward is here.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1638151 - Add support for nullable sequence types in Event classes. r=fabrice

Comment 2

[Simon Giesecke [:sg] [he/him]]

I added a case distinction for this. Apparently, Gecko itself has no events with any nullable sequence attribute. I would have added a test case, but the existing tests for Codegen.py do not seem to have any tests with events, so adding this is somewhat beyond my current understanding. Fabrice, could you try out the attached patch? Proper test cases might be added in a follow-up.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20304de817e4
Add support for nullable sequence types in Event classes. r=fabrice

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/20304de817e4