1638163 - Reduce includes of GeckoContentController.h just for its enums

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P1)

Description

[Kelsey Gilbert [:jgilbert]]

GeckoContentController::TapType and GeckoContentController::APZStateChange are used in a number of surprisingly-widely-included headers. For include-hygeine sake, it would be nice to split these out into a more-standalone header.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1638163 - Reduce unnecessary GeckoContentController.h includes.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cec3221b9268
Reduce unnecessary GeckoContentController.h includes. r=kats

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for bustage on APZCTreeManagerChild.cpp

backout: https://hg.mozilla.org/integration/autoland/rev/79cae1a3d97b8c00a1a120ab7322f566f4a20b2f

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=PuDYYGKeS4y7GdA8wCyWdg-0&group_state=expanded&revision=cec3221b9268d7f9346acc238a22d0541ce49a57&searchStr=build

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302499685&repo=autoland&lineNumber=33855

[task 2020-05-15T20:16:22.217Z] 20:16:22 INFO - In file included from Unified_cpp_gfx_layers8.cpp:11:
[task 2020-05-15T20:16:22.217Z] 20:16:22 INFO - /builds/worker/checkouts/gecko/gfx/layers/ipc/APZCTreeManagerChild.cpp(132,15): error: member access into incomplete type 'mozilla::layers::GeckoContentController'
[task 2020-05-15T20:16:22.217Z] 20:16:22 INFO - controller->HandleTap(aType, aPoint, aModifiers, aGuid, aInputBlockId);
[task 2020-05-15T20:16:22.217Z] 20:16:22 INFO - ^
[task 2020-05-15T20:16:22.217Z] 20:16:22 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/layers/CompositorBridgeParent.h(90,7): note: forward declaration of 'mozilla::layers::GeckoContentController'
[task 2020-05-15T20:16:22.217Z] 20:16:22 INFO - class GeckoContentController;
[task 2020-05-15T20:16:22.217Z] 20:16:22 INFO - ^
[task 2020-05-15T20:16:22.217Z] 20:16:22 INFO - 1 error generated.
[task 2020-05-15T20:16:22.217Z] 20:16:22 INFO - /builds/worker/checkouts/gecko/config/rules.mk:746: recipe for target 'Unified_cpp_gfx_layers8.obj' failed
[task 2020-05-15T20:16:22.217Z] 20:16:22 ERROR - make[4]: *** [Unified_cpp_gfx_layers8.obj] Error 1
[task 2020-05-15T20:16:22.217Z] 20:16:22 INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/gfx/layers'
[task 2020-05-15T20:16:22.218Z] 20:16:22 INFO - make[4]: *** Waiting for unfinished jobs....

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/847598557f09
Reduce unnecessary GeckoContentController.h includes. r=kats

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/847598557f09