1638243 - Intermittent Assertion failure: promises->IsEmpty(), at /builds/worker/checkouts/gecko/dom/media/GraphDriver.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect)

Description

[Karl Tomlinson (:karlt)]

Assertion failure: promises->IsEmpty(), at /builds/worker/checkouts/gecko/dom/media/GraphDriver.cpp:537
#01: mozilla::AudioCallbackDriver::~AudioCallbackDriver() [dom/media/GraphDriver.cpp:533]
#02: mozilla::AudioCallbackDriver::Release() [dom/media/GraphDriver.h:560]
#03: mozilla::MediaTrackGraphImpl::OneIterationImpl(long long, long long, mozilla::AudioMixer*) [dom/media/MediaTrackGraph.cpp:1430]
#04: mozilla::GraphRunner::Run() [dom/media/GraphRunner.cpp:114]
#05: nsThread::ProcessNextEvent(bool, bool*) [mfbt/RefPtr.h:314]
#06: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:501]
#07: mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:332]
#08: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:291]
#09: nsThread::ThreadFunc(void*) [xpcom/threads/nsThread.cpp:446]
#10: _pt_root [nsprpub/pr/src/pthreads/ptthread.c:204]

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302075028&repo=autoland&lineNumber=1314

The crash stack is slightly more intuitive than the assertion stack:
~AudioCallbackDriver()
https://hg.mozilla.org/mozilla-central/annotate/b9feee4f447c/dom/media/GraphDriver.cpp#l537
https://hg.mozilla.org/mozilla-central/annotate/b9feee4f447c/dom/media/GraphDriver.cpp#l533
AudioCallbackDriver::Release()
https://hg.mozilla.org/mozilla-central/annotate/b9feee4f447c/dom/media/GraphDriver.h#l560
MediaTrackGraphImpl::OneIterationImpl() calling SwitchAtNextIteration(nullptr)
https://hg.mozilla.org/mozilla-central/annotate/b9feee4f447c/dom/media/MediaTrackGraph.cpp#l1427
GraphRunner::Run()
https://hg.mozilla.org/mozilla-central/annotate/b9feee4f447c/dom/media/GraphRunner.cpp#l114

Seen only on MacOS, so far.
https://hg.mozilla.org/integration/autoland/rev/b9feee4f447c402f251b5a0647f999ac0bb798df would have made this more frequent, but has since been backed out.

Comment 1

[Karl Tomlinson (:karlt)]

mNextDriver can get a promise on Resume or Suspend.

Looks like there's nothing to remove those if the graph finishes running and mNextDriver is cleared.

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1638243 reject promises for Resume AudioContextOperations that have not run by graph shutdown r?padenot

The promises are rejected before shutdown down threads so that they don't need
to wait for nested event loops to exit.

Depends on D76806

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/121dfca01d6a
reject promises for Resume AudioContextOperations that have not run by graph shutdown r=padenot

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/121dfca01d6a

Comment 5

[Intermittent Failures Robot]

1 failures in 5211 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform breakdown:

• linux1804-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1638243&startday=2020-06-08&endday=2020-06-14&tree=all