1638244 - Intermittent clang AssertionError

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[Razvan Maries]

TH link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=toolchains%2Copt%2Ctoolchain%2Cbuilds%2Cfor%2Clinux%2C64-bits%2Ctoolchain-linux64-clang-7%2Ctl%28clang7%29&revision=2a9cf23c30710f2384a9aee5bad39fc2d80236e5&selectedTaskRun=F2qtXKtbTqOwHZaExJ6meQ-3

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302407207&repo=autoland&lineNumber=170

[task 2020-05-15T06:09:58.914Z] --------------------------
[task 2020-05-15T06:09:58.914Z] |We currently need this patch because ASan only searches PATH to find the
[task 2020-05-15T06:09:58.914Z] |llvm-symbolizer binary to symbolize ASan traces. On testing machines, this
[task 2020-05-15T06:09:58.914Z] |can be installed in PATH easily. However, for e.g. the ASan Nightly Project,
[task 2020-05-15T06:09:58.914Z] |where we ship an ASan build, including llvm-symbolizer, to the user, we
[task 2020-05-15T06:09:58.914Z] |cannot expect llvm-symbolizer to be on PATH. Instead, we should try to look
[task 2020-05-15T06:09:58.914Z] |it up next to the binary. This patch implements the functionality for Linux
[task 2020-05-15T06:09:58.914Z] |only until there is similar functionality provided upstream.
[task 2020-05-15T06:09:58.914Z] |
[task 2020-05-15T06:09:58.914Z] |diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_file.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_file.cpp
[task 2020-05-15T06:09:58.914Z] |index 79930d79425..cfb4f90c0d5 100644
[task 2020-05-15T06:09:58.914Z] |--- a/compiler-rt/lib/sanitizer_common/sanitizer_file.cpp
[task 2020-05-15T06:09:58.914Z] |+++ b/compiler-rt/lib/sanitizer_common/sanitizer_file.cpp
[task 2020-05-15T06:09:58.914Z] --------------------------
[task 2020-05-15T06:09:58.914Z] File to patch:
[task 2020-05-15T06:09:58.914Z] Skip this patch? [y]
[task 2020-05-15T06:09:58.914Z] 2 out of 2 hunks ignored
[task 2020-05-15T06:09:58.915Z] Traceback (most recent call last):
[task 2020-05-15T06:09:58.915Z] File "/builds/worker/workspace/build/src/build/build-clang/build-clang.py", line 699, in <module>
[task 2020-05-15T06:09:58.915Z] patch(os.path.join(config_dir, p), source_dir)
[task 2020-05-15T06:09:58.915Z] File "/builds/worker/workspace/build/src/build/build-clang/build-clang.py", line 87, in patch
[task 2020-05-15T06:09:58.915Z] '-s'])
[task 2020-05-15T06:09:58.915Z] File "/builds/worker/workspace/build/src/build/build-clang/build-clang.py", line 72, in check_run
[task 2020-05-15T06:09:58.915Z] assert r == 0
[task 2020-05-15T06:09:58.915Z] AssertionError
[fetches 2020-05-15T06:09:58.920Z] removing /builds/worker/fetches
[fetches 2020-05-15T06:10:00.625Z] finished
[taskcluster 2020-05-15 06:10:00.951Z] === Task Finished ===
[taskcluster 2020-05-15 06:10:01.064Z] Artifact "public/build" not found at "/builds/worker/artifacts/"
[taskcluster 2020-05-15 06:10:01.217Z] Unsuccessful task run with exit code: 1 completed in 35.994 seconds

From riot: tom.prince: Probably worth filing a but in any case, since I suspect it may have something to do with not cleaning the checkout up properly for those tasks.

Comment 1

[(Away)]

Attachment: Keep clang-7 toolchain on the old version of the find_symbolizer_linux patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a9ba4dd166d
Keep clang-7 toolchain on the old version of the find_symbolizer_linux patch r=froydnj

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3a9ba4dd166d