1638334 - WebExtension bookmarks context menu in library window has some bugs

Status: RESOLVED DUPLICATE of bug 1768371

(WebExtensions :: Frontend, defect, P5)

Description

[kernp25]

Attachment: manifest.zip

The context menu item will appear for items, that are not really bookmarks.
And when using it with apis like bookmarks.get(), it will fail.

Comment 1

[kernp25]

Attachment: firefox_wEbQXho8vI.png

The menus.OnClickData and the error, that was thrown when using bookmarks.get() for an invalid bookmark.

Comment 2

[kernp25]

Attachment: firefox_93pKWGF6uI.png

The context menu item will appear for invalid bookmarks in the library window.

Comment 3

[kernp25]

Attachment: IMHxxrY64n.png

It will appear for these items.

Comment 4

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=24f969298ec5c1a7cbc444bfc8f3d77b07f46bbe&tochange=f2f4a6eb1576cba580ee99971f5fc035cbaeeab1

Suspect: 8b35181c3ccc747106037b61a9b52adfbba5ed60 Peter Simonyi — Bug 1419195: Show items from WebExtensions in Places Library context menu r=mixedpuppy

Looks like an implementation bug.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 6

[Rob Wu [:robwu]]

To fix this, https://searchfox.org/mozilla-central/rev/df4c90d4b8c92c99f76334acfe4813c573c12661/browser/components/extensions/parent/ext-menus.js#1200 should be updated to filter those items, using PlacesUtils.isVirtualLeftPaneItem(node.bookmarkGuid).

Comment 7

[Rob Wu [:robwu]]

The suggestion from comment 6 has been applied in the patch to bug 1768371, so I'll close this bug.