1638361 - Crash in [@ std::thread::local::fast::Key<T>::try_initialize]

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P3)

Description

[Andrew McCreight (out until 2026) [:mccr8]]

This bug is for crash report bp-17d7a20c-1dee-4b25-8baf-e2a660200515.

Top 10 frames of crashing thread:

0 libxul.so RustMozCrash mozglue/static/rust/wrappers.cpp:17
1 libxul.so mozglue_static::panic_hook mozglue/static/rust/lib.rs:89
2 libxul.so core::ops::function::Fn::call src/libcore/ops/function.rs:72
3 libxul.so std::panicking::rust_panic_with_hook src/libstd/panicking.rs:474
4 libxul.so rust_begin_unwind src/libstd/panicking.rs:378
5 libxul.so std::panicking::begin_panic_fmt src/libstd/panicking.rs:332
6 libxul.so std::thread::local::fast::Key<T>::try_initialize third_party/rust/rand/src/rngs/thread.rs:65
7 libxul.so uuid::v4::<impl uuid::Uuid>::new_v4 
8 libxul.so mdns_service_generate_uuid media/mtransport/mdns_service/src/lib.rs:624
9 libxul.so mozilla::NrIceCtx::GenerateObfuscatedAddress media/mtransport/nricectx.cpp:1061

Bug 1624253 landed a patch to fix this crash, but the crash seems to have continued unabated. Fortunately it looks like it is Nightly-only.

Comment 2

[Dan Minor [:dminor]]

Oops, wrong crash!

Comment 3

[Dan Minor [:dminor]]

I wonder why it is Nightly only, bug 1624253 was for Nightly 77. Also seems strange that the panic catch does not work.

Comment 4

[Dan Minor [:dminor]]

Hi Kershaw, I'd like to use nsIUUIDGenerator from the socket process, but I'm getting NS_ERROR_FACTORY_NOT_REGISTERED when I attempt to use it. Same code works fine in the content process. I was hoping you might know what it would take to get this working in the socket process, or be able to point me towards someone else to ask. I was working around this by using a Rust uuid library, but we're seeing panics in the library code. Thank you!

Comment 5

[Andrew McCreight (out until 2026) [:mccr8]]

I think you need to add an entry 'processes': ProcessSelector.ALLOW_IN_SOCKET_PROCESS, to the XPCOM manifest for the UUID generator: https://searchfox.org/mozilla-central/rev/3ce874dc2703831af3e5ef3a1d216ffd08057fa5/xpcom/build/components.conf#200-204

Comment 6

[Kershaw Chang [:kershaw] PTO until Jan 2]

(In reply to Andrew McCreight [:mccr8] from comment #5)

I think you need to add an entry 'processes': ProcessSelector.ALLOW_IN_SOCKET_PROCESS, to the XPCOM manifest for the UUID generator: https://searchfox.org/mozilla-central/rev/3ce874dc2703831af3e5ef3a1d216ffd08057fa5/xpcom/build/components.conf#200-204

Yes, this is the answer. Thanks!

Comment 7

[Dan Minor [:dminor]]

Yes, that is working. Thanks!

Comment 8

[Dan Minor [:dminor]]

Attachment: Bug 1638361 - Allow nsIUUIDGenerator to be used from socket process; r=froydnj!

Comment 9

[Dan Minor [:dminor]]

Attachment: Bug 1638361 - Use nsIUUIDGenerator in NrIceCtx::GenerateObfuscatedAddress; r=mjf!

Depends on D76706

Comment 10

[Dan Minor [:dminor]]

Small try run here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e31fd0a25444d084ca9efcbc8b21f1c99b6aa56. The wpt failures are a pre-existing condition.

Comment 11

[Dan Minor [:dminor]]

Attachment: Bug 1638361 - Remove uuid generation code from mdns_service; r=mjf!

Depends on D76707

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/366588977080
Allow nsIUUIDGenerator to be used from socket process; r=froydnj
https://hg.mozilla.org/integration/autoland/rev/8687f7e8ad91
Use nsIUUIDGenerator in NrIceCtx::GenerateObfuscatedAddress; r=mjf
https://hg.mozilla.org/integration/autoland/rev/e9d71adb2de9
Remove uuid generation code from mdns_service; r=mjf

Comment 13

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/366588977080
https://hg.mozilla.org/mozilla-central/rev/8687f7e8ad91
https://hg.mozilla.org/mozilla-central/rev/e9d71adb2de9