1638426 - Add ability to disable PiP interventions.

Status: RESOLVED FIXED

(Web Compatibility :: Interventions, task, P2)

Description

[Mike Taylor [:miketaylr]]

Currently we have prefs that allow you to disable injections and overrides, but nothing for PiP interventions. It would be useful to be able to disable them when testing things during development.

Do we also want to display these in about:compat? Or is that not very useful?

Comment 1

[Mike Taylor [:miketaylr]]

Adam, how important do you think this is?

Comment 3

[Mike Taylor [:miketaylr]]

Adam, how important do you think this is?

I should clarify -- disabling globally seems important. How important is showing these in about:compat?

Comment 4

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1638426 - Add ability to disable webcompat picture-in-picture interventions, either globally or per-intervention; r?denschub

Comment 5

[Thomas Wisniewski [:twisniewski]]

It's worth noting that a restart seems to be required before pref flips for picture-in-picture interventions have an effect. That said, the patch adds these prefs (which we can tweak as desired before landing):

• global pref for all interventions:
  extensions.webcompat.enable_picture_in_picture_overrides
• per-intervention pref:
  enable_picture_in_picture_overrides.disabled_picture_in_picture_overrides.{twitch|instagram|etc}

Comment 6

[Dennis Schubert [:denschub]]

(In reply to Thomas Wisniewski [:twisniewski] from comment #5)

It's worth noting that a restart seems to be required before pref flips for picture-in-picture interventions have an effect.

This is a bit worrying to me, and I see a huge risk of confusing here. extensions.webcompat.perform_injections and extensions.webcompat.perform_ua_overrides both work without restarting and will actually reset themselves on restart, which is in direct contrast to the PiP pref.

I assume you have investigated that, and did not find a way to disable the interventions without a restart?

Comment 7

[Thomas Wisniewski [:twisniewski]]

After chatting with :mstriemer, I think we can do this by adding a new observer to the picture-in-picture code which the addon can use to signal whenever the interventions change (right now it only reads the values once).

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/062052fe43ff
Add ability to disable webcompat picture-in-picture interventions, either globally or per-intervention; r=denschub,webcompat-reviewers,mconley

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/062052fe43ff