Decision task's 'tests-by-manifests.json' artifact doesn't use proper WPT group ids
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(firefox79 fixed)
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(2 files)
This is because it's simply grabbing them from the TestResolver:
https://searchfox.org/mozilla-central/rev/3ce874dc2703831af3e5ef3a1d216ffd08057fa5/taskcluster/taskgraph/decision.py#233
Whereas they aren't created until later in the taskgraph:
https://searchfox.org/mozilla-central/rev/3ce874dc2703831af3e5ef3a1d216ffd08057fa5/taskcluster/taskgraph/util/chunking.py#75
We could either refactor the decision.py code to use the taskgraph generate values, or preferably, move the group creation into the TestResolver. This way TestResolver would have access to proper group IDs as well.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
WPT loads test metadata after the fact (and it is the same regardless of the
loader being used). This adds a file called 'wpt_manifest_data.json' which,
combined with the related fixture, can mock out what WPT's manifestupdate
script returns.
|
|
Assignee | |
Comment 3•4 years ago
|
||
For most test suites, the manifest id is the same as its relative path from
mozilla-central. But for WPT they are different. We decided to store the ids
in the 'manifest' attribute rather than 'manifest_relpath' since the latter
implies it is a file system path (which WPT manifest ids are not).
This patch takes this difference into account in
'TestResolver.tests_by_manifest'. It will consequently get the proper manifest
ids stored in the Decision task's 'tests-by-manifest.json.gz'.
Depends on D79338
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a32629c216af [moztest] Add ability to test web-platform-tests in the TestResolver, r=egao https://hg.mozilla.org/integration/autoland/rev/ccb1c8b879a6 [moztest] Use proper group and test ids for WPT from TestResolver.tests_by_manifest, r=egao
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a32629c216af
https://hg.mozilla.org/mozilla-central/rev/ccb1c8b879a6
Description
•