Closed Bug 1638438 Opened 2 years ago Closed 2 years ago

The webext_storage_bridge crate is compiled on Android

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 78
Tracking Flags:
Tracking Status
firefox78 --- fixed

People

(Reporter: eoger, Assigned: lina)

Details

Attachments

(1 file)

Bug 1638438 - Don't link `webext_storage_bridge` on Android. r?eoger!
47 bytes, text/x-phabricator-request
Details | Review

We do not want to ship webext_storage_bridge on GeckoView builds, so we should conditionally compile this crate.

We ship the mozIExtensionStorageArea interface on Android, so that
GeckoView can eventually provide its own implementation, but not the
C++ glue for the XPCOM class...so we shouldn't be linking the bridge
into gkrust, either.

This commit also removes Rusqlite linking, since it's now linked in
via webext_storage_bridge => webext_storage => rusqlite.

Assignee: nobody → lina
Status: NEW → ASSIGNED
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/22a66a638fe5
Don't link `webext_storage_bridge` on Android. r=eoger

Our apologies for this, but we had to backout your patch because was blocking the backout of Bug 1631630 which caused mass browser-chrome failures.
Sorry for the inconvenience!

Flags: needinfo?(lina)
Backout by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99e688a54911
Backed out changeset 22a66a638fe5 for causing hunk failed on another backout
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f612f25d6c8f
Don't link `webext_storage_bridge` on Android. r=eoger

https://hg.mozilla.org/mozilla-central/rev/f612f25d6c8f

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
Flags: needinfo?(lina)
You need to log in before you can comment on or make changes to this bug.