Closed
Bug 1638438
Opened 10 months ago
Closed 10 months ago
The webext_storage_bridge crate is compiled on Android
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 78
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: eoger, Assigned: lina)
Details
Attachments
(1 file)
We do not want to ship webext_storage_bridge
on GeckoView builds, so we should conditionally compile this crate.
Assignee | ||
Comment 1•10 months ago
|
||
We ship the mozIExtensionStorageArea
interface on Android, so that
GeckoView can eventually provide its own implementation, but not the
C++ glue for the XPCOM class...so we shouldn't be linking the bridge
into gkrust, either.
This commit also removes Rusqlite linking, since it's now linked in
via webext_storage_bridge => webext_storage => rusqlite.
Updated•10 months ago
|
Assignee: nobody → lina
Status: NEW → ASSIGNED
Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/22a66a638fe5 Don't link `webext_storage_bridge` on Android. r=eoger
Comment 3•10 months ago
|
||
Our apologies for this, but we had to backout your patch because was blocking the backout of Bug 1631630 which caused mass browser-chrome failures.
Sorry for the inconvenience!
Flags: needinfo?(lina)
Backout by nerli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/99e688a54911 Backed out changeset 22a66a638fe5 for causing hunk failed on another backout
Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f612f25d6c8f Don't link `webext_storage_bridge` on Android. r=eoger
Comment 6•10 months ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
Assignee | ||
Updated•5 months ago
|
Flags: needinfo?(lina)
You need to log in
before you can comment on or make changes to this bug.
Description
•