1638452 - Intermittent dom/media/test/test_hls_player_independency.html | Test timed out.

Status: RESOLVED FIXED

(GeckoView :: Media, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=302498542&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/QR6NuZLZTvShqGoaAH47Mg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-05-15T20:06:41.308Z] 20:00:58 INFO - 230 INFO TEST-START | dom/media/test/test_hls_player_independency.html
[task 2020-05-15T20:06:41.308Z] 20:06:19 INFO - Buffered messages logged at 20:00:52
[task 2020-05-15T20:06:41.308Z] 20:06:19 INFO - 231 INFO TEST-PASS | dom/media/test/test_hls_player_independency.html | A valid string reason is expected
[task 2020-05-15T20:06:41.308Z] 20:06:19 INFO - 232 INFO TEST-PASS | dom/media/test/test_hls_player_independency.html | Reason cannot be empty
[task 2020-05-15T20:06:41.308Z] 20:06:19 INFO - Buffered messages logged at 20:00:58
[task 2020-05-15T20:06:41.308Z] 20:06:19 INFO - 233 INFO TEST-PASS | dom/media/test/test_hls_player_independency.html | 4x3 content, the width should be 400.
[task 2020-05-15T20:06:41.308Z] 20:06:19 INFO - 234 INFO TEST-PASS | dom/media/test/test_hls_player_independency.html | 4x3 content, the height should be 300.
[task 2020-05-15T20:06:41.308Z] 20:06:19 INFO - Buffered messages finished
[task 2020-05-15T20:06:41.308Z] 20:06:19 WARNING - 235 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_hls_player_independency.html | Test timed out.
[task 2020-05-15T20:06:41.308Z] 20:06:19 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:299:16
[task 2020-05-15T20:06:41.308Z] 20:06:19 INFO - reportError@SimpleTest/TestRunner.js:128:22
[task 2020-05-15T20:06:41.308Z] 20:06:19 INFO - TestRunner._checkForHangs@SimpleTest/TestRunner.js:150:18
[task 2020-05-15T20:06:41.308Z] 20:06:19 INFO - 236 INFO {"EMEInfo":{"keySystem":"","sessionsInfo":""},"compositorDroppedFrames":0,"decoder":{"PlayState":"ENDED","channels":2,"containerType":"application/x-mpegurl","hasAudio":true,"hasVideo":true,"instance":"7996ee4c00","rate":22050,"reader":{"audioChannels":2,"audioDecoderName":"android decoder (remote)","audioFramesDecoded":108,"audioRate":22.049999237060547,"audioState":{"demuxEOS":1,"demuxQueueSize":0,"drainState":0,"hasDecoder":false,"hasDemuxRequest":false,"hasPromise":false,"lastStreamSourceID":1,"needInput":false,"numSamplesInput":108,"numSamplesOutput":108,"pending":0,"queueSize":0,"timeTreshold":-1,"timeTresholdHasSeeked":false,"waitingForData":false,"waitingForKey":false,"waitingPromise":false},"audioType":"audio/mp4a-latm","frameStats":{"droppedCompositorFrames":0,"droppedDecodedFrames":0,"droppedSinkFrames":1},"videoDecoderName":"android decoder (remote)","videoHardwareAccelerated":true,"videoHeight":300,"videoNumSamplesOutputTotal":145,"videoNumSamplesSkippedTotal":0,"videoRate":29.783342361450195,"videoState":{"demuxEOS":1,"demuxQueueSize":0,"drainState":0,"hasDecoder":false,"hasDemuxRequest":false,"hasPromise":false,"lastStreamSourceID":4,"needInput":false,"numSamplesInput":164,"numSamplesOutput":145,"pending":0,"queueSize":19,"timeTreshold":-1,"timeTresholdHasSeeked":false,"waitingForData":false,"waitingForKey":false,"waitingPromise":false},"videoType":"video/avc","videoWidth":400},"resource":{"cacheStream":{"cacheSuspended":false,"channelEnded":false,"channelOffset":0,"loadID":0,"streamLength":0}},"stateMachine":{"audioCompleted":true,"audioRequestStatus":"idle","clock":-1,"decodedAudioEndTime":5015501,"decodedVideoEndTime":5034111,"duration":5034111,"isPlaying":false,"mediaSink":{"audioSinkWrapper":{"audioEnded":true,"audioSink":{"audioEnded":false,"hasErrored":false,"isPlaying":false,"isStarted":false,"lastGoodPosition":0,"outputRate":0,"playbackComplete":false,"startTime":0,"written":0},"isPlaying":false,"isStarted":false},"decodedStream":{"audioQueueFinished":false,"audioQueueSize":0,"data":{"audioFramesWritten":0,"haveSentFinishAudio":false,"haveSentFinishVideo":false,"instance":"","lastVideoEndTime":0,"lastVideoStartTime":0,"nextAudioTime":0,"streamAudioWritten":0,"streamVideoWritten":0},"instance":"","lastAudio":0,"lastOutputTime":0,"playing":0,"startTime":0},"videoSink":{"endPromiseHolderIsEmpty":true,"finished":true,"hasVideo":true,"isPlaying":false,"isStarted":false,"size":0,"videoFrameEndTime":0,"videoSinkEndRequestExists":false}},"mediaTime":5034111,"playState":4,"sentFirstFrameLoadedEvent":true,"state":"","stateObj":{"isPrerolling":false},"videoCompleted":true,"videoRequestStatus":"idle"}}}
[task 2020-05-15T20:06:41.308Z] 20:06:19 INFO - 237 INFO {"EMEInfo":{"keySystem":"","sessionsInfo":""},"compositorDroppedFrames":0,"d

Comment 1

[Intermittent Failures Robot]

1 failures in 5488 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• android-hw-p2-8-0-android-aarch64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1638452&startday=2020-05-11&endday=2020-05-17&tree=all

Comment 2

[Intermittent Failures Robot]

1 failures in 5458 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform breakdown:

• android-em-7-0-x86_64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1638452&startday=2020-05-25&endday=2020-05-31&tree=all

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Comment 4

[Intermittent Failures Robot]

1 failures in 4516 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 1

Platform breakdown:

• android-em-7-0-x86_64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1638452&startday=2020-06-29&endday=2020-07-05&tree=all

Comment 5

[Alexandru Michis [:malexandru]]

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309515373&repo=autoland&lineNumber=2417

Comment 6

[Intermittent Failures Robot]

1 failures in 5265 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• android-hw-p2-8-0-android-aarch64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1638452&startday=2020-07-06&endday=2020-07-12&tree=all

Comment 7

[Geoff Brown [:gbrown]]

[task 2020-07-12T19:27:08.313Z] 19:21:46     INFO -  228 INFO TEST-START | dom/media/test/test_hls_player_independency.html
[task 2020-07-12T19:27:08.313Z] 19:26:57     INFO -  Buffered messages logged at 19:21:36
[task 2020-07-12T19:27:08.313Z] 19:26:57     INFO -  229 INFO TEST-PASS | dom/media/test/test_hls_player_independency.html | A valid string reason is expected
[task 2020-07-12T19:27:08.313Z] 19:26:57     INFO -  230 INFO TEST-PASS | dom/media/test/test_hls_player_independency.html | Reason cannot be empty
[task 2020-07-12T19:27:08.313Z] 19:26:57     INFO -  Buffered messages logged at 19:21:42
[task 2020-07-12T19:27:08.313Z] 19:26:57     INFO -  231 INFO TEST-PASS | dom/media/test/test_hls_player_independency.html | 4x3 content, the width should be 400.
[task 2020-07-12T19:27:08.313Z] 19:26:57     INFO -  232 INFO TEST-PASS | dom/media/test/test_hls_player_independency.html | 4x3 content, the height should be 300.
[task 2020-07-12T19:27:08.313Z] 19:26:57     INFO -  Buffered messages finished
[task 2020-07-12T19:27:08.314Z] 19:26:57  WARNING -  233 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_hls_player_independency.html | Test timed out.
[task 2020-07-12T19:27:08.314Z] 19:26:57     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:409:16
[task 2020-07-12T19:27:08.314Z] 19:26:57     INFO -      reportError@SimpleTest/TestRunner.js:138:22
[task 2020-07-12T19:27:08.314Z] 19:26:57     INFO -      TestRunner._checkForHangs@SimpleTest/TestRunner.js:160:18
[task 2020-07-12T19:27:08.314Z] 19:26:57     INFO -  234 INFO {"EMEInfo":{"keySystem":"","sessionsInfo":""},"compositorDroppedFrames":0,"decoder":{"PlayState":"ENDED","channels":2,"containerType":"application/x-mpegurl","hasAudio":true,"hasVideo":true,"instance":"769f22e400","rate":22050,"reader":{"audioChannels":2,"audioDecoderName":"android decoder (remote)","audioFramesDecoded":105,"audioRate":22.049999237060547,"audioState":{"demuxEOS":1,"demuxQueueSize":0,"drainState":0,"hasDecoder":false,"hasDemuxRequest":false,"hasPromise":false,"lastStreamSourceID":1,"needInput":false,"numSamplesInput":105,"numSamplesOutput":105,"pending":0,"queueSize":0,"timeTreshold":-1,"timeTresholdHasSeeked":false,"waitingForData":false,"waitingForKey":false,"waitingPromise":false},"audioType":"audio/mp4a-latm","frameStats":{"droppedCompositorFrames":0,"droppedDecodedFrames":0,"droppedSinkFrames":0},"videoDecoderName":"android decoder (remote)","videoHardwareAccelerated":true,"videoHeight":300,"videoNumSamplesOutputTotal":146,"videoNumSamplesSkippedTotal":0,"videoRate":29.766679763793945,"videoState":{"demuxEOS":1,"demuxQueueSize":0,"drainState":0,"hasDecoder":false,"hasDemuxRequest":false,"hasPromise":false,"lastStreamSourceID":3,"needInput":false,"numSamplesInput":146,"numSamplesOutput":146,"pending":0,"queueSize":0,"timeTreshold":-1,"timeTresholdHasSeeked":false,"waitingForData":false,"waitingForKey":false,"waitingPromise":false},"videoType":"video/avc","videoWidth":400},"resource":{"cacheStream":{"cacheSuspended":false,"channelEnded":false,"channelOffset":0,"loadID":0,"streamLength":0}},"stateMachine":{"audioCompleted":true,"audioRequestStatus":"idle","clock":-1,"decodedAudioEndTime":4919724,"decodedVideoEndTime":4938334,"duration":4938334,"isPlaying":false,"mediaSink":{"audioSinkWrapper":{"audioEnded":true,"audioSink":{"audioEnded":false,"hasErrored":false,"isPlaying":false,"isStarted":false,"lastGoodPosition":0,"outputRate":0,"playbackComplete":false,"startTime":0,"written":0},"isPlaying":false,"isStarted":false},"decodedStream":{"audioQueueFinished":false,"audioQueueSize":0,"data":{"audioFramesWritten":0,"haveSentFinishAudio":false,"haveSentFinishVideo":false,"instance":"","lastVideoEndTime":0,"lastVideoStartTime":0,"nextAudioTime":0,"streamAudioWritten":0,"streamVideoWritten":0},"instance":"","lastAudio":0,"lastOutputTime":0,"playing":0,"startTime":0},"videoSink":{"endPromiseHolderIsEmpty":true,"finished":true,"hasVideo":true,"isPlaying":false,"isStarted":false,"size":0,"videoFrameEndTime":0,"videoSinkEndRequestExists":false}},"mediaTime":4938334,"playState":4,"sentFirstFrameLoadedEvent":true,"state":"","stateObj":{"isPrerolling":false},"videoCompleted":true,"videoRequestStatus":"idle"}}}
[task 2020-07-12T19:27:08.314Z] 19:26:57     INFO -  235 INFO {"EMEInfo":{"keySystem":"","sessionsInfo":""},"compositorDroppedFrames":0,"decoder":{"PlayState":"PLAYING","channels":2,"containerType":"application/x-mpegurl","hasAudio":true,"hasVideo":true,"instance":"769f236800","rate":22050,"reader":{"audioChannels":2,"audioDecoderName":"android decoder (remote)","audioFramesDecoded":24,"audioRate":22.049999237060547,"audioState":{"demuxEOS":0,"demuxQueueSize":0,"drainState":0,"hasDecoder":false,"hasDemuxRequest":false,"hasPromise":false,"lastStreamSourceID":2,"needInput":false,"numSamplesInput":5,"numSamplesOutput":1,"pending":0,"queueSize":4,"timeTreshold":-1,"timeTresholdHasSeeked":false,"waitingForData":false,"waitingForKey":false,"waitingPromise":false},"audioType":"audio/mp4a-latm","frameStats":{"droppedCompositorFrames":0,"droppedDecodedFrames":0,"droppedSinkFrames":0},"videoDecoderName":"android decoder (remote)","videoHardwareAccelerated":true,"videoHeight":234,"videoNumSamplesOutputTotal":35,"videoNumSamplesSkippedTotal":0,"videoRate":29.96927833557129,"videoState":{"demuxEOS":0,"demuxQueueSize":0,"drainState":0,"hasDecoder":true,"hasDemuxRequest":false,"hasPromise":true,"lastStreamSourceID":4,"needInput":false,"numSamplesInput":62,"numSamplesOutput":35,"pending":0,"queueSize":27,"timeTreshold":-1,"timeTresholdHasSeeked":false,"waitingForData":false,"waitingForKey":false,"waitingPromise":false},"videoType":"video/avc","videoWidth":416},"resource":{"cacheStream":{"cacheSuspended":false,"channelEnded":false,"channelOffset":0,"loadID":0,"streamLength":0}},"stateMachine":{"audioCompleted":false,"audioRequestStatus":"idle","clock":1113125,"decodedAudioEndTime":1114550,"decodedVideoEndTime":1201200,"duration":4040000,"isPlaying":true,"mediaSink":{"audioSinkWrapper":{"audioEnded":false,"audioSink":{"audioEnded":false,"hasErrored":false,"isPlaying":true,"isStarted":false,"lastGoodPosition":1113125,"outputRate":48000,"playbackComplete":false,"startTime":0,"written":53430},"isPlaying":true,"isStarted":true},"decodedStream":{"audioQueueFinished":false,"audioQueueSize":0,"data":{"audioFramesWritten":0,"haveSentFinishAudio":false,"haveSentFinishVideo":false,"instance":"","lastVideoEndTime":0,"lastVideoStartTime":0,"nextAudioTime":0,"streamAudioWritten":0,"streamVideoWritten":0},"instance":"","lastAudio":0,"lastOutputTime":0,"playing":0,"startTime":0},"videoSink":{"endPromiseHolderIsEmpty":false,"finished":false,"hasVideo":true,"isPlaying":true,"isStarted":true,"size":3,"videoFrameEndTime":1134466,"videoSinkEndRequestExists":false}},"mediaTime":1113125,"playState":3,"sentFirstFrameLoadedEvent":true,"state":"","stateObj":{"isPrerolling":false},"videoCompleted":false,"videoRequestStatus":"pending"}}}
[task 2020-07-12T19:27:08.314Z] 19:26:57     INFO -  236 INFO TEST-OK | dom/media/test/test_hls_player_independency.html | took 312236ms

Logcat, https://firefoxci.taskcluster-artifacts.net/GIbZlA0gSl-ej905DHQFyQ/0/public/test_info/logcat-FA84C1A00167.log has lots of output for se
veral minutes, until the test times out:

07-12 19:21:39.146  6806  9764 D GeckoHlsAudioRenderer: positionUs = 1515000, mInputStreamEnded = false
07-12 19:21:39.153  6806  9769 D GeckoHlsVideoRenderer: positionUs = 2475000, mInputStreamEnded = false
07-12 19:21:39.153  6806  9769 D GeckoHlsAudioRenderer: positionUs = 2475000, mInputStreamEnded = false
07-12 19:21:39.156  6806  9764 D GeckoHlsVideoRenderer: positionUs = 1525000, mInputStreamEnded = false
07-12 19:21:39.156  6806  9764 D GeckoHlsAudioRenderer: positionUs = 1525000, mInputStreamEnded = false
...
07-12 19:26:48.661  6806  9769 D GeckoHlsAudioRenderer: positionUs = 311983000, mInputStreamEnded = false
07-12 19:26:48.671  6806  9769 D GeckoHlsVideoRenderer: positionUs = 311993000, mInputStreamEnded = false
07-12 19:26:48.672  6806  9769 D GeckoHlsAudioRenderer: positionUs = 311993000, mInputStreamEnded = false
07-12 19:26:48.682  6806  9769 D GeckoHlsVideoRenderer: positionUs = 312004000, mInputStreamEnded = false
07-12 19:26:48.682  6806  9769 D GeckoHlsAudioRenderer: positionUs = 312004000, mInputStreamEnded = false

Comment 8

[Intermittent Failures Robot]

1 failures in 4289 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• android-hw-p2-8-0-android-aarch64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1638452&startday=2020-07-27&endday=2020-08-02&tree=all

Comment 9

[Intermittent Failures Robot]

50 failures in 958 pushes (0.052 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 40
• mozilla-central: 9
• try: 1

Platform breakdown:

• android-em-7-0-x86_64-qr: 36
• android-em-7-0-x86_64: 6
• android-hw-p2-8-0-android-aarch64: 3
• android-em-7-0-x86_64-shippable: 3
• android-em-7-0-x86_64-shippable-qr: 1
• android-hw-p2-8-0-android-aarch64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1638452&startday=2020-08-06&endday=2020-08-06&tree=all

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1651088 landed directly before the test failed for the first time. The failures are so frequent the test would get disabled for the failure rate. John, please investigate.

Comment 11

[Andreea Pavel [:apavel]]

Retriggers: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=H5bE4ps1RPenMxucqjKu2g.0&searchStr=android%2C7.0%2Cx86-64%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Csocket%2Cprocess%2Ctest-android-em-7.0-x86_64-qr%2Fdebug-geckoview-mochitest-media-spi-e10s%2Cmda&tochange=b67ba5d335d839674cf6f97a85a2e3a4e64c26bb&fromchange=6f90335f9391ac2825e2bc37f8a6c4f6600a8412

Comment 12

[Intermittent Failures Robot]

28 failures in 956 pushes (0.029 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 15
• mozilla-central: 8
• try: 5

Platform breakdown:

• android-em-7-0-x86_64-qr: 12
• android-hw-p2-8-0-android-aarch64: 2
• android-em-7-0-x86_64-shippable-qr: 1
• android-em-7-0-x86_64-shippable: 3
• android-hw-p2-8-0-android-aarch64-shippable: 4
• android-em-7-0-x86_64: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1638452&startday=2020-08-07&endday=2020-08-07&tree=all

Comment 13

[Intermittent Failures Robot]

98 failures in 4618 pushes (0.021 failures/push) were associated with this bug in the last 7 days.

This is the #7 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 72
• mozilla-central: 19
• try: 7

Platform breakdown:

• android-em-7-0-x86_64-qr: 54
• android-em-7-0-x86_64: 18
• android-hw-p2-8-0-android-aarch64: 12
• android-em-7-0-x86_64-shippable: 6
• android-em-7-0-x86_64-shippable-qr: 2
• android-hw-p2-8-0-android-aarch64-shippable: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1638452&startday=2020-08-03&endday=2020-08-09&tree=all

Comment 14

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1638452 - don't hold lock while waiting player thread. r?snorp

Comment 15

[John Lin [:jhlin][:jolin]]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #10)

Bug 1651088 landed directly before the test failed for the first time. The failures are so frequent the test would get disabled for the failure rate. John, please investigate.

Thanks a lot for identifying the regression. It turns out the patch for bug 1651088 holds a lock while waiting for the player thread and could cause dead lock. Fix already uploaded for review.

Comment 16

[Intermittent Failures Robot]

16 failures in 784 pushes (0.02 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 9
• try: 4
• mozilla-central: 3

Platform breakdown:

• android-em-7-0-x86_64: 3
• android-em-7-0-x86_64-qr: 9
• android-em-7-0-x86_64-shippable-qr: 2
• android-hw-p2-8-0-android-aarch64: 1
• android-em-7-0-x86_64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1638452&startday=2020-08-10&endday=2020-08-10&tree=all

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06456f429c22
don't hold lock while waiting player thread. r=snorp,geckoview-reviewers

Comment 18

[Ryan VanderMeulen [:RyanVM]]

I did a bunch of autoland retriggers and it looks like this worked. Please proceed with approval requests when you're able.

Comment 19

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/06456f429c22

Comment 20

[Intermittent Failures Robot]

19 failures in 655 pushes (0.029 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 8
• mozilla-central: 7
• try: 4

Platform breakdown:

• android-em-7-0-x86_64-qr: 5
• android-hw-p2-8-0-android-aarch64: 5
• android-em-7-0-x86_64-shippable-qr: 3
• android-em-7-0-x86_64-shippable: 2
• android-em-7-0-x86_64: 3
• android-hw-p2-8-0-android-aarch64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1638452&startday=2020-08-11&endday=2020-08-11&tree=all

Comment 21

[John Lin [:jhlin][:jolin]]

Comment on attachment 9169336 [details]
Bug 1638452 - don't hold lock while waiting player thread. r?snorp

Beta/Release Uplift Approval Request

• User impact if declined: Browser hangs when playing HLS video.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1651088
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patche reduces the span of lock.
• String changes made/needed: N/A

Comment 22

[John Lin [:jhlin][:jolin]]

Comment on attachment 9169336 [details]
Bug 1638452 - don't hold lock while waiting player thread. r?snorp

Beta/Release Uplift Approval Request

• User impact if declined: Browser hangs when playing HLS video.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1651088
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch reduce the span of lock.
• String changes made/needed: N/A

Comment 23

[Julien Cristau [:jcristau]]

Comment on attachment 9169336 [details]
Bug 1638452 - don't hold lock while waiting player thread. r?snorp

approved for 80.0b8

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c2ab721868e7

Comment 25

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9169336 [details]
Bug 1638452 - don't hold lock while waiting player thread. r?snorp

Approved for Fenix 79.0.5.

Comment 26

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/af6d7e906784

Comment 27

[Intermittent Failures Robot]

35 failures in 3601 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

This is the #13 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 17
• try: 8
• mozilla-central: 10

Platform breakdown:

• android-em-7-0-x86_64: 6
• android-em-7-0-x86_64-qr: 14
• android-em-7-0-x86_64-shippable-qr: 5
• android-hw-p2-8-0-android-aarch64: 6
• android-em-7-0-x86_64-shippable: 3
• android-hw-p2-8-0-android-aarch64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1638452&startday=2020-08-10&endday=2020-08-16&tree=all

Comment 28

[Intermittent Failures Robot]

1 failures in 3810 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• android-em-7-0-x86_64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1638452&startday=2021-01-11&endday=2021-01-17&tree=all

Comment 29

[Chris Peterson [:cpeterson]]

Moving some media bugs to the new GeckoView::Media component.