1638460 - Warp: Support transpiling Calls to known natives

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Tom S [:evilpie]]

We can transpile the CacheIR sequence: GuardSpecificFunction + CallNativeFunction. This gives us the actual JSNative that is going to be called. With this Ion can emit LCallNative instead of the much more generic LCallGeneric.

We should probably refactor some of this code to be like IonBuilder using makeCallHelper and createThis. This seems to pass jit-tests for calls. The construct case actually can't be hit yet.

Comment 1

[Tom S [:evilpie]]

Attachment: Bug 1638460 - Warp: Support transpiling Calls to known natives. r?jandem

Comment 2

[Tom S [:evilpie]]

Attachment: Bug 1638460 - Create a WarpBuilderShared base class. r?jandem

Comment 3

[Tom S [:evilpie]]

Attachment: Bug 1638460 - Factor out the MCall creation logic to makeCall. r?jandem

Depends on D75700

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ba73d568aff
Create a WarpBuilderShared base class. r=jandem
https://hg.mozilla.org/integration/autoland/rev/6159717a9c66
Factor out the MCall creation logic to makeCall. r=jandem
https://hg.mozilla.org/integration/autoland/rev/a69152ce5537
Warp: Support transpiling Calls to known natives. r=jandem

Comment 5

[Cristian Brindusan [:cbrindusan]]

Backed out 3 changesets (Bug 1638460) for sm bustages at WarpCacheIRTranspiler.cpp
https://hg.mozilla.org/integration/autoland/rev/eb94a03438d1db4f5604885e317dc5b3654a5a59

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=a69152ce5537820611365d2a11e7e884cb6950a1&selectedTaskRun=XgIoItfrRCapcVlxFDuKSg-0

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302809057&repo=autoland&lineNumber=5286

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a30a6284ece
Create a WarpBuilderShared base class. r=jandem
https://hg.mozilla.org/integration/autoland/rev/3ec24f39d775
Factor out the MCall creation logic to makeCall. r=jandem
https://hg.mozilla.org/integration/autoland/rev/d052be2448b1
Warp: Support transpiling Calls to known natives. r=jandem

Comment 7

[Tom S [:evilpie]]

I didn't #ifdef JS_SIMULATOR properly. Kind of unfortunate that it actually changes the parameter list. I wonder if there is some better way of doing this.

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0a30a6284ece
https://hg.mozilla.org/mozilla-central/rev/3ec24f39d775
https://hg.mozilla.org/mozilla-central/rev/d052be2448b1