Closed Bug 1638583 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 23657 - Fix missing borders on narrow elements

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23657 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23657
Details from upstream follow.

Stephen Chenney <schenney@chromium.org> wrote:

Fix missing borders on narrow elements

A recent change for painting narrow elements whose widths falls below 0.5
under zoom has caused problems when such elements have a single pixel border.
In such cases, the element size, including the border, is greater than
1 and snaps normally, but the inner border rect has non zero size below
0.5 and snaps up to size 1, instead of zero. As a result the inner border
rects is the same as the out border rect and the border is clipped out.

Here we change the rounding for inner border rect to not enforce the
non-zero-width constraint, as it is inappropriate in this case.

Bug: 1070091
Change-Id: Ia368ca00375fe5d8a060b88c2d9e314f25679b07
Reviewed-on: https://chromium-review.googlesource.com/2204362
WPT-Export-Revision: ed39981d4af747ed5c4a770f90bdc90dd43c1bb2

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b40e6d32a17f [wpt PR 23657] - Fix missing borders on narrow elements, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.