Last Comment Bug 163869 - unsubscribe alert is showing wrong newsserver if newsserver has been changed
: unsubscribe alert is showing wrong newsserver if newsserver has been changed
Status: RESOLVED FIXED
[good first bug][mentor=mkmelin]
:
Product: MailNews Core
Classification: Components
Component: Networking: NNTP (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 24.0
Assigned To: Suyash Agarwal (:sshagarwal)
:
:
Mentors:
http://hg.mozilla.org/comm-central/an...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2002-08-21 07:25 PDT by Henrik Gemal
Modified: 2013-06-25 05:18 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (1.04 KB, patch)
2013-05-18 23:33 PDT, Suyash Agarwal (:sshagarwal)
Pidgeot18: review+
mkmelin+mozilla: feedback+
Details | Diff | Splinter Review

Description Henrik Gemal 2002-08-21 07:25:50 PDT
if you create a newsserver like news.mozilla.org and subscribe to a newsgroup
and then in the account manager, change the newsgroup server from
news.mozilla.org to fx forums.macromedia.com and then mozilla is checking for
new messages on the news server you get a alert saying:
"groups netscape.public.mozilla.dom was not found on news.mozilla.org"
while it's actually on forums.macromedia.com

20020821
Comment 1 (not reading, please use seth@sspitzer.org instead) 2007-06-21 15:00:58 PDT
sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.
Comment 2 Serge Gautherie (:sgautherie) 2008-06-20 10:44:01 PDT
Filter on "Nobody_NScomTLD_20080620"
Comment 3 Joshua Cranmer [:jcranmer] 2010-10-16 20:00:01 PDT
The dialog needs to be updated to use RealHostName instead of HostName.
Comment 4 Magnus Melin 2013-05-18 04:27:19 PDT
Looks like it needs to be changed here:
http://hg.mozilla.org/comm-central/annotate/9637efa949a4/mailnews/news/src/nsNntpIncomingServer.cpp#l1571
Comment 5 Suyash Agarwal (:sshagarwal) 2013-05-18 23:33:23 PDT
Created attachment 751429 [details] [diff] [review]
Patch

Sir,

I have tried to make the change and tested it on "news-archive.icm.edu.pl". It seems to work fine.
Comment 6 Magnus Melin 2013-05-19 03:13:19 PDT
Comment on attachment 751429 [details] [diff] [review]
Patch

Review of attachment 751429 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok to me. I'm not a reviewer for this code though, so redirecting the review to Joshua.
Comment 7 Ryan VanderMeulen [:RyanVM] 2013-05-28 10:18:28 PDT
https://hg.mozilla.org/comm-central/rev/844fca307f5d

Note You need to log in before you can comment on or make changes to this bug.