163869 - unsubscribe alert is showing wrong newsserver if newsserver has been changed

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[Henrik Gemal]

if you create a newsserver like news.mozilla.org and subscribe to a newsgroup
and then in the account manager, change the newsgroup server from
news.mozilla.org to fx forums.macromedia.com and then mozilla is checking for
new messages on the news server you get a alert saying:
"groups netscape.public.mozilla.dom was not found on news.mozilla.org"
while it's actually on forums.macromedia.com

20020821

Comment 1

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 2

[Serge Gautherie (:sgautherie)]

Filter on "Nobody_NScomTLD_20080620"

Comment 3

[Joshua Cranmer [:jcranmer]]

The dialog needs to be updated to use RealHostName instead of HostName.

Comment 4

[Magnus Melin [:mkmelin]]

Looks like it needs to be changed here:
http://hg.mozilla.org/comm-central/annotate/9637efa949a4/mailnews/news/src/nsNntpIncomingServer.cpp#l1571

Comment 5

[Suyash Agarwal (:sshagarwal)]

Attachment: Patch

Sir,

I have tried to make the change and tested it on "news-archive.icm.edu.pl". It seems to work fine.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 751429 [details] [diff] [review]
Patch

Review of attachment 751429 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok to me. I'm not a reviewer for this code though, so redirecting the review to Joshua.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/844fca307f5d