1638927 - Replace dedicated `XULStore` thread with background tasks

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, task, P3)

Description

[Lina Butler (ex-Mozilla)]

XULStore currently spins up its own thread for background persistence. We can replace this with a call to dispatch_background_task in persist—I don't think we even need a queue in this case.

Comment 1

[Lina Butler (ex-Mozilla)]

Attachment: Bug 1638927 - Replace dedicated `XULStore` persistence thread with background tasks. r?KrisWright!

Depends on D75863

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48cd04b805d0
Replace dedicated `XULStore` persistence thread with background tasks. r=KrisWright

Comment 3

[Atila Butkovits]

Backed out changeset (Bug 1638927) 48cd04b805d0 Mochitest failures at inline_lazy.rs
https://hg.mozilla.org/integration/autoland/rev/3362d9133ec346616292a5f86e020a79cf163126

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=48cd04b805d0bbb95db34ba34aca8427e4e32fd6&selectedTaskRun=EaFcNIKpQ6-X5xdE8h-IAQ-0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303208758&repo=autoland&lineNumber=1978

Comment 4

[Lina Butler (ex-Mozilla)]

Hmmm, I wonder if it's the same thing as this GitHub issue. Since we already have once_cell in the tree, and it seems to have a better threading story, let's give it a try.

Comment 5

[Lina Butler (ex-Mozilla)]

Attachment: Bug 1638927 - Replace `lazy_static` with `once_cell` in XULStore. r?froydnj!

TSan returns false positives for lazy_static. While we could
blocklist it, once_cell has equivalent functionality, but with a more
modern API, so let's use it instead.

Depends on D75864

Comment 6

[Lina Butler (ex-Mozilla)]

TSan seems happier, let's land it!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5b5927ff37ed63a659b623421e8e4b850ec7e70&selectedTaskRun=MKw8ICkVQpqgqMleB-sK9w-0

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89d99941f3af
Replace dedicated `XULStore` persistence thread with background tasks. r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/1785974f69f2
Replace `lazy_static` with `once_cell` in XULStore. r=froydnj

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/89d99941f3af
https://hg.mozilla.org/mozilla-central/rev/1785974f69f2