Closed
Bug 1638928
Opened 5 years ago
Closed 5 years ago
Remove "Get" prefix from nsIFrame's GetChildLists and GetCrossChildLists
Categories
(Core :: Layout, task)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla78
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(3 files)
Filed per mats' comment,
"Get" is typically used for things that are fallible in one way or another, or may return a null-pointer etc.
Both methods always return child lists in an array (though the array may be empty), so it makes sense to remove the "Get" prefix in their naming.
Assignee | ||
Comment 1•5 years ago
|
||
This patch is generated by using my editor's rename functionality.
Assignee | ||
Comment 2•5 years ago
|
||
This patch is generated by using my editor's rename functionality.
nsIFrame::
prefix from all the ChildLists() calls will removed
manually in the next patch.
Depends on D75892
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D75893
Updated•5 years ago
|
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9ab0705fc439
Part 1 - Rename nsIFrame's GetCrossDocChildLists() to CrossDocChildLists(). r=mats
https://hg.mozilla.org/integration/autoland/rev/3678c95fb3cf
Part 2 - Rename nsIFrame's GetChildLists() to ChildLists(). r=mats
https://hg.mozilla.org/integration/autoland/rev/d3db4eba3a3b
Part 3 - Remove redundant "nsIFrame::" prefix from ChildLists() calls. r=mats
Comment 5•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9ab0705fc439
https://hg.mozilla.org/mozilla-central/rev/3678c95fb3cf
https://hg.mozilla.org/mozilla-central/rev/d3db4eba3a3b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•