1638957 - Convert 'mach devtools-css-db' to run with Python 3

Status: RESOLVED FIXED

(DevTools :: General, task)

Description

[Kris Wright :KrisWright]

mach devtools-css-db still runs with python 2 [1]. We want to convert all mach commands to python 3.

To do this, any dependencies of the command may need to be converted as well as the command itself.

[1] https://searchfox.org/mozilla-central/rev/9193635dca8cfdcb68f114306194ffc860456044/devtools/shared/css/generated/mach_commands.py

Comment 1

[Ricky Stewart]

Hi, is there a status update on this work?

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Greg, I am seeing that you introduced this command in bug 1290988. Do you know what we need to change to make the command python 3 compatible?
Thanks!
Honza

Comment 3

[Greg Tatum [:gregtatum]]

I see two options here:

1. Convert to python 3
2. Remove this feature

For 1, I think following the steps from the meta bug would be adequate. I think it would be changing this over to python 3, and chasing down the errors and dependencies.

For 2, I have a suspicion that this is no longer needed. This feature was added when we were trying to separate the client and servers better. I'm not sure how much this is still a goal. I think this is only used in rare edge cases. I know I felt that it wasn't a great solution, but it helped get the project done, which was fairly complicated. I also believe some of the DevTools features that were relying on this are now gone, which makes fully removing it simpler.

The key here is to try and remove getClientCssProperties.

I think it would be worth pursuing option 2, as I know the CSS and DOM teams would appreciate not having to mess with this any more.

Comment 4

[[e-mail] (:bhearsum)]

Sounds like we're not ready to remove this yet. I went ahead and added python3 support to this command (patch incoming), as it was pretty trivial.

Comment 5

[[e-mail] (:bhearsum)]

Attachment: Bug 1638957: run 'mach devtools-css-db' under python 3. r=#releng-reviewers

It's not 100% clear how long this command will live, but it doesn't look
immediately removable, and it was easy to add python3 support.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8eb79efa9347
run 'mach devtools-css-db' under python 3. r=releng-reviewers,aki DONTBUILD

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8eb79efa9347