1638962 - Remove unused and broken 'mach geckodriver-test'

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P3)

Description

[Kris Wright :KrisWright]

mach geckodriver-test still runs with python 2 [1]. We want to convert all mach commands to python 3.

To do this, any dependencies of the command may need to be converted as well as the command itself.

[1] https://searchfox.org/mozilla-central/rev/9193635dca8cfdcb68f114306194ffc860456044/testing/geckodriver/mach_commands.py

Comment 1

[Ankush Dua]

Hi Kris!... I would love to contribute to this issue. Under your guidance if possible because I am new the codebase 😃

Comment 2

[James Graham [:jgraham]]

whimboo: do you ever use this one? The fact that it's totally broken suggests to me we should just delete it.

Comment 3

[Kris Wright :KrisWright]

(In reply to Ankush Dua from comment #1)

Hi Kris!... I would love to contribute to this issue. Under your guidance if possible because I am new the codebase 😃

Hello! Unfortunately this mach geckodriver-test seems to be completely broken, so it's not a good candidate for conversion. I'd recommend checking the metabug for other options, as it's likely we'll just delete this command.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to James Graham [:jgraham] from comment #2)

whimboo: do you ever use this one? The fact that it's totally broken suggests to me we should just delete it.

Our docs (Testing.md) refer to ./mach test testing/geckodriver. So when we remove this command we will have to update the docs and tell that cargo test will have to be used.

It would still be good to have this command available which could run all the tests including webdriver, and mozdevice.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1638962 - [geckodriver] Remove broken geckodriver-test mach command.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bea7d70862b0
[geckodriver] Remove broken geckodriver-test mach command. r=webdriver-reviewers,jgraham

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bea7d70862b0