Closed Bug 1638966 Opened 11 months ago Closed 7 months ago

Convert 'mach hazards' to run with Python 3

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: KrisWright, Assigned: sfink)

References

Details

Attachments

(1 file)

mach hazards still runs with python 2 [1]. We want to convert all mach commands to python 3.

To do this, any dependencies of the command may need to be converted as well as the command itself.

[1] https://searchfox.org/mozilla-central/rev/9193635dca8cfdcb68f114306194ffc860456044/s/src/devtools/rootAnalysis/mach_commands.py

The only thing that keeps mach hazards on py2 is that it invokes build commands internally. It should be possible to remove hazards from the list at the same time as build.

Severity: -- → S3
Priority: -- → P3

mach build has been running with Python 3 since bug 1617748, i.e., 5 months ago :)

Hi -- is there a status update on this work?

Flags: needinfo?(sdetar)

Steve, could help provide any new status to Ricky

Flags: needinfo?(sdetar) → needinfo?(sphink)
Assignee: nobody → sphink
Status: NEW → ASSIGNED

Hm, I know at the time I implemented this command, mach build was definitely marked as running under py2. Maybe I was based off an old version. But whatever; I just tried running it under py3 and everything worked fine.

Flags: needinfo?(sphink)
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/80a9f72ef6fb
Run `mach hazards` under py3 r=rstewart
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.