163898 - Feature request for Insert text Command for Editor Embedding

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[David Epstein]

Add an InsertText() method in nsICommandManager or nsICommandParams interface.
Or add insertText command option in nsICommandManager->DoCommand(). This would
allow text to be easily inserted in editor context for text operations.

Comment 1

[David Epstein]

changed qa contact to depstein

Comment 2

[Kathleen :Brade]

*** Bug 171762 has been marked as a duplicate of this bug. ***

Comment 3

[Charles Manske]

I need this implemented asap to use with some editorshell removal work, so I'll
take this bug.

Comment 4

[Charles Manske]

Attachment: InsertPlaintext and InsertHTML commands v1

It seemed logical to also implement insertHTML while I was at it.
This uses "doCommandParams": set the text to insert in the "TEXT" param value
for "cmd_insertPlaintext" and set the HTML source in the "HTML" param value for

"cmd_insertHTML"

Comment 5

[mjudge]

Comment on attachment 103534 [details] [diff] [review]
InsertPlaintext and InsertHTML commands v1

marking it reviewed.  I think you should change the "TEXT" and "HTML" to
"state_data" for each.	keeps in the same design as most of the other attribute
calls. "state_attribute"  We will most likely be having more of these insert
type commands in the future so maybe a generice "state_data" would be better.

Comment 6

[Charles Manske]

Ok, I can see having generic param identifiers.
I'll use "state_data" and "state_attribute"

Comment 7

[Simon Fraser [no longer active]]

+NS_IMETHODIMP
+nsInsertPlaintextCommand::DoCommand(const char *aCommandName, nsISupports *refCon)
+{
+  return NS_OK;
+}

and

+NS_IMETHODIMP
+nsInsertHTMLCommand::DoCommand(const char *aCommandName, nsISupports *refCon)
+{
+  return NS_OK;
+}

Return NS_ERROR_NOT_IMPLEMENTED from the old-style DoCommands.

When these commands are documented, we need to say if they replace the current
selection.

Is there a bug for commmands to get the contents/selection as text/html?

Comment 8

[Simon Fraser [no longer active]]

Comment on attachment 103534 [details] [diff] [review]
InsertPlaintext and InsertHTML commands v1

sr=sfraser with mike's and my changes

Comment 9

[Charles Manske]

Ok, NS_ERROR_NOT_IMPLEMENTED used as requested.
No, I don't know of any other RFEs for new commands. Good idea!

Comment 10

[Charles Manske]

checked into 1.3a trunk